Add pagination to channel pages #354

Merged

6ea86b96 merged 2 commits from infinite-scroll into master

2017-07-29 21:35:45 +02:00

6ea86b96 commented

2017-07-17 08:15:20 +02:00

(Migrated from github.com)

Switched channel claims to lookup from claims.byId
Added pagination
Added ability to use pagination params in the URL

For some reason the container doesn't auto resize though and I haven't been able to figure out why yet.

![pagination](https://user-images.githubusercontent.com/20863631/28746140-6dca6ebe-74b0-11e7-8759-6b6d520d92ab.gif) - [x] Switched channel claims to lookup from `claims.byId` - [x] Added pagination - [x] Added ability to use pagination params in the URL For some reason the container doesn't auto resize though and I haven't been able to figure out why yet.

kauffj (Migrated from github.com) reviewed 2017-07-17 08:15:20 +02:00

hackrush01 commented

2017-07-17 10:25:33 +02:00

(Migrated from github.com)

@6ea86b96 @kauffj @lyoshenka

I have some suggestions regarding this.

Instead of auto-scrolling it should be paginated, as infinite scrolling is a bit tedious if you have to find some thing for the n^th time. So there should be page numbers at the bottom for navigation.
It should append some prompt on the address bar such as lbry://url&page=3 or lbry://url:3 so that user can type in that and directly reach to that page, or share the page with people.
(Super Optional) Maybe the user could set the no. of results to be displayed on one page?

P.S. #351 is dependent on this.

@6ea86b96 @kauffj @lyoshenka I have some suggestions regarding this. 1. Instead of auto-scrolling it should be paginated, as infinite scrolling is a bit tedious if you have to find some thing for the n<sup>th</sup> time. So there should be page numbers at the bottom for navigation. 2. It should append some prompt on the address bar such as `lbry://url&page=3` or `lbry://url:3` so that user can type in that and directly reach to that page, or share the page with people. 3. (Super Optional) Maybe the user could set the no. of results to be displayed on one page? P.S. #351 is dependent on this.

6ea86b96 commented

2017-07-18 05:32:10 +02:00

(Migrated from github.com)

Good point. Pagination would be a lot more usable.

kauffj commented

2017-07-19 22:31:54 +02:00

(Migrated from github.com)

@6ea86b96 did you want me to review/merge this as-is? I got the impression you were planning to come back to it.

6ea86b96 commented

2017-07-20 07:09:07 +02:00

(Migrated from github.com)

@kauffj Removed you as a reviewer for now. I like the pagination suggestion. I'm going to come back to this after the channel surfing rewards fix.

6ea86b96 commented

2017-07-23 18:20:00 +02:00

(Migrated from github.com)

Added pagination, just need to get the css working and it's good to go.

6ea86b96 commented

2017-07-29 17:52:49 +02:00

(Migrated from github.com)

@kauffj pagination is working now. Doesn't look that amazing. CSS is not my strong point :)

hackrush01 commented

2017-07-29 20:39:06 +02:00

(Migrated from github.com)

@6ea86b96 I was just trying it out, but I found one issue, it seems to work with the provided version of the lbrynet-daemon but not with the latest version(with the latest lbryum and schema). One possible reason I've singled out is that it may be happening due to this PR. Could you please check it out once?

kauffj commented

2017-07-29 21:39:19 +02:00

(Migrated from github.com)

@hackrush01 it worked fine for me after I rebased onto master.

@6ea86b96 merged. Added my own CSS, which I also don't like. I did clean up the class names, though.

@hackrush01 it worked fine for me after I rebased onto master. @6ea86b96 merged. Added my own CSS, which I also don't like. I did clean up the class names, though.