Support claims that are also downloaded show in publish, other inconsistencies. #384

Closed
opened 2017-07-25 23:26:01 +02:00 by tzarebczan · 6 comments
tzarebczan commented 2017-07-25 23:26:01 +02:00 (Migrated from github.com)

The Issue

Originally introduced here: https://github.com/lbryio/lbry-app/issues/315

Background: I have added support to lbry://ten at claimid: f4d5521279b783416bf6950b506f852105e8968e

Two main issues arise:

  1. My Publishes page shows support claims for other claims which I have added support to. Since we will be adding Support functionality in the UI, shouldn't LBRY list the supports somewhere? The content we are supporting may or may not be on the Publishes page. We can leave this as another enhancement and fix the immediate issue for now.

  2. Publish page takes my supports into account when determining my ownership of a lbry URI. i.e. I supported lbry://ten, and when I type ten in Publish as a URI, it says I own it.

UPDATE: #1/2 above are still happening in v16 with the caveat that the supported claim needs to be downloaded to reproduce the issue. #2 is compounded on the claim page now because it will show an Edit button.

Steps to reproduce

  1. Add support to a claim
  2. Go to Publishes page, it shows there
  3. Go to Publish page and try to use that URI, it shows as taken
  4. try to go to permanent URL of that claim - empty claim or metadata info.

Expected behaviour

Supports should be disregarded for time being

Actual behaviour

Supports mess up Publishes/Publish

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

have claim support shows as my claim
empty
publishes

<!-- Thanks for reporting an issue to LBRY and helping us improve! To make it possible for us to help you, please fill out below information carefully. Before reporting any issues, please make sure that you're using the latest version. - App releases: https://github.com/lbryio/lbry-app/releases - Standalone daemon: https://github.com/lbryio/lbry/releases We are also available on Slack at https://slack.lbry.io --> ## The Issue Originally introduced here: https://github.com/lbryio/lbry-app/issues/315 Background: I have added support to lbry://ten at claimid: f4d5521279b783416bf6950b506f852105e8968e Two main issues arise: 1) My Publishes page shows support claims for other claims which I have added support to. Since we will be adding Support functionality in the UI, shouldn't LBRY list the supports somewhere? The content we are supporting may or may not be on the Publishes page. We can leave this as another enhancement and fix the immediate issue for now. 2) Publish page takes my supports into account when determining my ownership of a lbry URI. i.e. I supported lbry://ten, and when I type ten in Publish as a URI, it says I own it. UPDATE: #1/2 above are still happening in v16 with the caveat that the supported claim needs to be downloaded to reproduce the issue. #2 is compounded on the claim page now because it will show an Edit button. ### Steps to reproduce 1. Add support to a claim 2. Go to Publishes page, it shows there 3. Go to Publish page and try to use that URI, it shows as taken 4. try to go to permanent URL of that claim - empty claim or metadata info. ### Expected behaviour Supports should be disregarded for time being ### Actual behaviour Supports mess up Publishes/Publish ## System Configuration <!-- For the app, this info is in the About section at the bottom of the Help page. You can include a screenshot instead of typing it out --> <!-- For the daemon, run: curl 'http://localhost:5279/lbryapi' --data '{"method":"version"}' and include the full output --> - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else <!-- Include anything else that does not fit into the above sections --> ## Screenshots <!-- If a screenshot would help explain the bug, please include one or two here --> ![have claim support shows as my claim](https://user-images.githubusercontent.com/8120721/28594552-5f50e516-715e-11e7-931c-3177c63322de.PNG) ![empty](https://user-images.githubusercontent.com/8120721/28594576-75c74560-715e-11e7-8ab7-88b118ea0feb.PNG) ![publishes](https://user-images.githubusercontent.com/8120721/28594602-98f2f764-715e-11e7-8820-aab4f30e39c0.PNG)
tzarebczan commented 2017-07-26 16:34:57 +02:00 (Migrated from github.com)

Found another issue related to above. When I go to lbry://ten, it also thinks I own the file and can't download it / but it prompts me to abandon my claim. Removing it does nothing, goes back to "Open" state.
10

Found another issue related to above. When I go to lbry://ten, it also thinks I own the file and can't download it / but it prompts me to abandon my claim. Removing it does nothing, goes back to "Open" state. ![10](https://user-images.githubusercontent.com/8120721/28626811-1105c116-71ee-11e7-964e-9b4a1b63cbec.PNG)
tzarebczan commented 2017-09-20 00:56:09 +02:00 (Migrated from github.com)

UPDATE: #1/2 above are still happening in v16 with the caveat that the supported claim needs to be downloaded to reproduce the issue. #2 is compounded on the claim page now because it will show an Edit button. #3 still happened to me, but I used the incorrect claim_id, so that was an error on my part.

holi2

UPDATE: #1/2 above are still happening in v16 with the caveat that the supported claim needs to be downloaded to reproduce the issue. #2 is compounded on the claim page now because it will show an Edit button. #3 still happened to me, but I used the incorrect claim_id, so that was an error on my part. ![holi2](https://user-images.githubusercontent.com/8120721/30619199-2b70df96-9d6c-11e7-8e0d-c58cda727a25.JPG)
tzarebczan commented 2017-09-20 15:13:43 +02:00 (Migrated from github.com)

And he's a screenshot for the edit button of a claim I don't own (but support)
notmyfile

And he's a screenshot for the edit button of a claim I don't own (but support) ![notmyfile](https://user-images.githubusercontent.com/8120721/30645530-ff017ba0-9de3-11e7-8b05-f622ab280bba.JPG)
alyssaoc commented 2018-08-21 19:15:40 +02:00 (Migrated from github.com)

@tzarebczan is this still happening?

@tzarebczan is this still happening?
alyssaoc commented 2018-12-07 20:29:13 +01:00 (Migrated from github.com)

closing, reopen if this is still an issue

closing, reopen if this is still an issue
tzarebczan commented 2018-12-07 20:29:51 +01:00 (Migrated from github.com)

There's a newer issue filed for this, thanks!

There's a newer issue filed for this, thanks!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#384
No description provided.