Fix linting errors #397

Closed
opened 2017-07-27 21:38:20 +02:00 by lyoshenka · 4 comments
lyoshenka commented 2017-07-27 21:38:20 +02:00 (Migrated from github.com)

errors

![errors](http://i.imgur.com/oBgK8MV.png)
lyoshenka commented 2017-07-27 21:38:48 +02:00 (Migrated from github.com)

ASAR fix should be a separate ticket. I know we turned it off for a reason, but I don't know what that reason is.

ASAR fix should be a separate ticket. I know we turned it off for a reason, but I don't know what that reason is.
liamcardenas commented 2017-12-15 04:09:37 +01:00 (Migrated from github.com)

@IGassmann I'm making you aware of this old ticket in case its relevant to your current efforts, otherwise I will close it.

@IGassmann I'm making you aware of this old ticket in case its relevant to your current efforts, otherwise I will close it.
IGassmann commented 2017-12-15 05:05:00 +01:00 (Migrated from github.com)

Those are electron linting errors. I fixed the asar one when I was restructuring the file structure. Still have to check out the others.

Those are electron linting errors. I fixed the asar one when I was restructuring the file structure. Still have to check out the others.
IGassmann commented 2017-12-22 13:18:40 +01:00 (Migrated from github.com)

I'll use my time on this issue to refactor the main process to follow electron's best practices and get the code closer to the functional paradigm.

I'll use my time on this issue to refactor the main process to follow electron's best practices and get the code closer to the functional paradigm.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#397
No description provided.