don't use localstorage in Embed if not available #4017

Closed
opened 2020-04-17 20:40:41 +02:00 by tzarebczan · 3 comments
tzarebczan commented 2020-04-17 20:40:41 +02:00 (Migrated from github.com)

Brave, with shields, turned on blocks localstorage from being accessed via an iframe. Can we see if this happens and not read/store anything but still allow the embed?

image

Brave, with shields, turned on blocks localstorage from being accessed via an iframe. Can we see if this happens and not read/store anything but still allow the embed? ![image](https://user-images.githubusercontent.com/8120721/79602941-67fa8d80-80b9-11ea-8dc5-f89eaca8085d.png)
jeffslofish commented 2020-05-17 22:29:51 +02:00 (Migrated from github.com)

Looking into this...

Looking into this...
jeffslofish commented 2020-05-18 00:29:03 +02:00 (Migrated from github.com)

Pull request submitted =)

Pull request submitted =)
chron0 commented 2020-05-22 19:11:14 +02:00 (Migrated from github.com)

Seems to be working now in chromium on linux as well. Thanks a lot!

Seems to be working now in chromium on linux as well. Thanks a lot!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#4017
No description provided.