First attempt to fix #3993. #4019

Merged

jeffslofish merged 2 commits from issue-3993 into master

2020-04-21 23:07:57 +02:00

jeffslofish commented

2020-04-18 03:49:18 +02:00

(Migrated from github.com)

Show error message if image is not able to be displayed by browser.

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: #3993

What is the current behavior?

If a browser cannot display an image (such as Safari and WebP images), then an empty box is displayed in place of the image.

What is the new behavior?

If a browser cannot display an image, an error message is displayed in a Card.

Other information

Show error message if image is not able to be displayed by browser. ## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #3993 ## What is the current behavior? If a browser cannot display an image (such as Safari and WebP images), then an empty box is displayed in place of the image. ## What is the new behavior? If a browser cannot display an image, an error message is displayed in a Card. ## Other information

neb-b commented

2020-04-20 15:48:19 +02:00

(Migrated from github.com)

Thanks for this PR @jeffslofish! I'll review this today!

tzarebczan commented

2020-04-20 17:52:26 +02:00

(Migrated from github.com)

@jeffslofish Thanks again for the contribution! Reach out to us so we can show you some appreciation.

@jeffslofish Thanks again for the contribution! Reach out to us so we can [show you some appreciation](https://lbry.com/faq/appreciaiton).

kauffj commented

2020-04-20 23:42:14 +02:00

(Migrated from github.com)

Thanks for your contribution @jeffslofish 🙌

It's pretty obvious you know what you're doing, so if you have any thoughts or feedback on the setup and introductory development experience, we'd welcome your feedback.

Thanks for your contribution @jeffslofish :raised_hands: It's pretty obvious you know what you're doing, so if you have any thoughts or feedback on the setup and introductory development experience, we'd welcome your feedback.

neb-b (Migrated from github.com) requested changes

2020-04-20 23:59:00 +02:00

neb-b (Migrated from github.com) left a comment

Tested and it works great. Just one comment then I will merge!

ui/component/viewers/imageViewer.jsx

Can you remove this? That's only used for cards that should be collapsable.

jeffslofish commented

2020-04-21 00:54:58 +02:00

(Migrated from github.com)

Thanks for your contribution @jeffslofish 🙌

It's pretty obvious you know what you're doing, so if you have any thoughts or feedback on the setup and introductory development experience, we'd welcome your feedback.

@kauffj Yes I do have some feedback on the setup and introductory developer experience. Where is a good place to leave that feedback?

> Thanks for your contribution @jeffslofish 🙌 > > It's pretty obvious you know what you're doing, so if you have any thoughts or feedback on the setup and introductory development experience, we'd welcome your feedback. @kauffj Yes I do have some feedback on the setup and introductory developer experience. Where is a good place to leave that feedback?

neb-b commented

2020-04-21 19:57:02 +02:00

(Migrated from github.com)

@jeffslofish I just created this issue. Can you comment there?
https://github.com/lbryio/lbry-desktop/issues/4036

@jeffslofish I just created this issue. Can you comment there? https://github.com/lbryio/lbry-desktop/issues/4036