Add back 3d file viewer / fix cbz reader #4035

New issue

Closed

opened 2020-04-21 18:59:01 +02:00 by neb-b · 5 comments

neb-b commented

2020-04-21 18:59:01 +02:00

(Migrated from github.com)

After the file page refactoring, there are issues displaying 3d files.

It seems like some wrapper class is preventing the 3d canvas from expanding in height

After the file page refactoring, there are issues displaying 3d files. It seems like some wrapper class is preventing the 3d canvas from expanding in height

tzarebczan commented

2020-04-23 17:43:10 +02:00

(Migrated from github.com)

There's also bugs with the cbz reader: lbry://@injustice#3/01byInjustice-GodsAmongUs-Annual0012014digitalSonofUltron-Empirecbz#7

It won't load the first time and then crashes when you leave the page.

@btzr-io do you think you can work on these?

There's also bugs with the cbz reader: lbry://@injustice#3/01byInjustice-GodsAmongUs-Annual0012014digitalSonofUltron-Empirecbz#7 It won't load the first time and then crashes when you leave the page. @btzr-io do you think you can work on these?

btzr-io commented

2020-04-25 02:49:43 +02:00

(Migrated from github.com)

It won't load the first time and then crashes when you leave the page.

hmm I think I fixed that bug or a similar problem, I'll have to search for those commits 🙃

> It won't load the first time and then crashes when you leave the page. hmm I think I fixed that bug or a similar problem, I'll have to search for those commits 🙃

btzr-io commented

2020-04-25 09:20:00 +02:00

(Migrated from github.com)

It won't load the first time

See: Force non-streamable content to wait for download #4074

> It won't load the first time See: Force non-streamable content to wait for download #4074

btzr-io commented

2020-04-25 10:44:33 +02:00

(Migrated from github.com)

I fixed the 3d viewer styles, the same solution can be used for the comic viewer but the other errors are probably in the Villain side and I'll need to publish a new version once I figure out what is the error...

Anyway let me know if this still an issue, maybe I can fix it in the process: https://github.com/lbryio/lbry-desktop/issues/2777

I fixed the 3d viewer styles, the same solution can be used for the comic viewer but the other errors are probably in the `Villain` side and I'll need to publish a new version once I figure out what is the error... Anyway let me know if this still an issue, maybe I can fix it in the process: https://github.com/lbryio/lbry-desktop/issues/2777

tzarebczan commented

2020-05-06 02:47:35 +02:00

(Migrated from github.com)

These are now fixed, will open a new issue for the CBZ requiring download first.