LBRYCommunity/lbry-desktop

Fork 0

Bring back Wallet History page (transaction list data) #4052

New issue

Open

opened 2020-04-23 17:00:58 +02:00 by tzarebczan · 10 comments

tzarebczan commented

2020-04-23 17:00:58 +02:00

(Migrated from github.com)

We should still have a way to access transaction list data since it's more detailed than the current list and shows fees/abandons etc. It also allows export to xls and some creators use this for tracking their income.

It needs to be properly paginated, but no filters needed.

bitcoinbrisbane commented

2020-04-29 11:30:34 +02:00

(Migrated from github.com)

Wouldn't .csv be better than .xls?

Wouldn't `.csv` be better than `.xls`?

kauffj commented

2020-04-29 18:32:17 +02:00

(Migrated from github.com)

Yes, .csv over .xls 100%. It's probably pretty workable to add an export button to the current state of Transaction List. I added help wanted to this issue.

Yes, `.csv` over `.xls` 100%. It's probably pretty workable to add an export button to the current state of Transaction List. I added help wanted to this issue.

jeffslofish commented

2020-05-16 07:27:32 +02:00

(Migrated from github.com)

I'm working on this now.

jeffslofish commented

2020-05-16 09:48:47 +02:00

(Migrated from github.com)

What if we have a button on the wallet page called "Detailed History" that takes you to the old transactions page which has all the transaction list data. Or did you want to display the transaction list data right on the wallet page? I have the former working right now ... it would take some more work to display it on the wallet page.

kauffj commented

2020-05-20 01:46:54 +02:00

(Migrated from github.com)

Can we instead do this in a way that you "toggle" between extra details mode?

I dislike two distinct pagination methods that are 80% similar pretty strongly from a UX perspective.

Can we instead do this in a way that you "toggle" between extra details mode? I dislike two distinct pagination methods that are 80% similar pretty strongly from a UX perspective.

jeffslofish commented

2020-05-22 04:51:31 +02:00

(Migrated from github.com)

Is this more along the lines you were thinking?

https://open.lbry.com/@jeffslofish:7/wallet-history-test-2:3

Is this more along the lines you were thinking? https://open.lbry.com/@jeffslofish:7/wallet-history-test-2:3

kauffj commented

2020-05-22 21:56:08 +02:00

(Migrated from github.com)

@jeffslofish yes. Additional comments:

Would like a shorter label. If all that is added is fees, it can be labeled "Show Fees"
Ideally height would not "jump" when toggling. Can we show a busy indicator without trashing the current results?
The table looks like it could be smarter about widths (existing issue, but while you're there... 😁)
Can the flow to export be presented as one simple button labeled "Export"? The preparation can begin when the user requests it, rather than presenting as two steps

@jeffslofish yes. Additional comments: - Would like a shorter label. If all that is added is fees, it can be labeled "Show Fees" - Ideally height would not "jump" when toggling. Can we show a busy indicator without trashing the current results? - The table looks like it could be smarter about widths (existing issue, but while you're there... :grin:) - Can the flow to export be presented as one simple button labeled "Export"? The preparation can begin when the user requests it, rather than presenting as two steps

❤️ 1

kauffj commented

2020-05-22 21:56:54 +02:00

(Migrated from github.com)

@jeffslofish also, if you ever want prompt UI feedback, do not hesitate to @ me in Slack. I will almost always see and answer GitHub messages too, but I process these as lower priority emails.

hboisgibault commented

2021-10-09 11:16:05 +02:00

(Migrated from github.com)

Hi, is this issue still a thing ? I'm willing to help.

hboisgibault commented

2021-10-09 13:26:50 +02:00

(Migrated from github.com)

The fee attribute would be added to the list on toggle. I don't know how to handle filters and pagination since transactions cannot be filtered by "Active". Also, the redux action to fetch transactions does not have pagination.
A solution would be to allow to show fees only when there are no filters.

The fee attribute would be added to the list on toggle. I don't know how to handle filters and pagination since transactions cannot be filtered by "Active". Also, the redux action to fetch transactions does not have pagination. A solution would be to allow to show fees only when there are no filters.