[WIP] Support claim UI implementation #406

Closed
akinwale wants to merge 5 commits from ui-claim-support into master
akinwale commented 2017-07-30 16:46:57 +02:00 (Migrated from github.com)

Added the Support Claim link and inline form to the view media page.

I'm still not exactly sure where total claim support should be displayed. Should it be enclosed within brackets suffixed to the button label or in the inline form?

Added the Support Claim link and inline form to the view media page. I'm still not exactly sure where total claim support should be displayed. Should it be enclosed within brackets suffixed to the button label or in the inline form?
kauffj (Migrated from github.com) reviewed 2017-07-30 16:46:57 +02:00
6ea86b96 commented 2017-07-30 16:59:22 +02:00 (Migrated from github.com)

I think it might be good to create a actions/claims.js. There should be one already, this is my fault. There's also a bunch of code in actions/content.js which really should not be there too.

I think it might be good to create a `actions/claims.js`. There should be one already, this is my fault. There's also a bunch of code in `actions/content.js` which really should not be there too.
akinwale commented 2017-07-30 17:04:53 +02:00 (Migrated from github.com)

@6ea86b96 I guess this means I should also move the corresponding selectors and reducers from selectors/file_actions.js and reducers/file_actions.js to selectors/claims.js and reducers/claims.js respectively?

@6ea86b96 I guess this means I should also move the corresponding selectors and reducers from `selectors/file_actions.js` and `reducers/file_actions.js` to `selectors/claims.js` and `reducers/claims.js` respectively?
6ea86b96 commented 2017-07-30 17:06:07 +02:00 (Migrated from github.com)

IMO yes, the supports stuff fits into claims better than file actions.

IMO yes, the supports stuff fits into claims better than file actions.
kauffj commented 2017-08-12 22:06:09 +02:00 (Migrated from github.com)

This is in tip_and_supports branch and will come in via #391.

This is in `tip_and_supports` branch and will come in via #391.

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#406
No description provided.