Fix purchase confirmation logic #4071

Merged

jeffslofish merged 1 commit from issue-4057 into master

2020-04-27 15:53:33 +02:00

jeffslofish commented

2020-04-25 00:34:35 +02:00

(Migrated from github.com)

Closes #4057

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: #4057

What is the current behavior?

If "Always confirm before purchasing content" is selected in settings and the currency for "Only confirm purchases over a certain price" was previously set to USD, then an unnecessary check for exchange rates is occurring.

What is the new behavior?

The exchange rate is only checked if "Only confirm purchases over a certain price" is selected and the currency set to USD.

Other information

Thanks to @seanyesmunt for commit dcb79685bc which fixes part of #4057 as well.

Closes #4057 ## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #4057 ## What is the current behavior? If "Always confirm before purchasing content" is selected in settings and the currency for "Only confirm purchases over a certain price" was previously set to USD, then an unnecessary check for exchange rates is occurring. ## What is the new behavior? The exchange rate is only checked if "Only confirm purchases over a certain price" is selected and the currency set to USD. ## Other information Thanks to @seanyesmunt for commit https://github.com/lbryio/lbry-desktop/commit/dcb79685bc25cf3bc77d434255063fc4933cdf44 which fixes part of #4057 as well.