LBRYCommunity/lbry-desktop

Fork 0

Add Tooltips To Channel Action Buttons #4085

New issue

Closed

opened 2020-04-27 16:31:30 +02:00 by harshkhandeparkar · 9 comments

harshkhandeparkar commented

2020-04-27 16:31:30 +02:00

(Migrated from github.com)

First Timers Only

This issue is reserved for people who haven't contributed to our codebase before, or never contributed to Open Source. About First Timers Only.

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

What is to be done?

Currently only the Tip button on the channel pages has a tooltip.

Having tooltips on the other buttons will improve consistency and also be helpful.

🔎 Files To Look Into:

The Tip button, for reference.
8b6c644415/ui/page/channel/view.jsx (L203-L209)
The Follow/Unfollow button.
https://github.com/lbryio/lbry-desktop/blob/master/ui/component/subscribeButton/view.jsx
The Share button.
https://github.com/lbryio/lbry-desktop/blob/master/ui/component/shareButton/view.jsx
The Block button.
https://github.com/lbryio/lbry-desktop/blob/master/ui/component/blockButton/view.jsx

📋 Step by Step

📜 Read The CONTRIBUTING File: We welcome contributions from everyone, the CONTRIBUTING will help you get started.

NOTE: Useful links:

- Git Commands
- Installation Instructions
Fork This Repository: A fork is a copy of this repository that is stored under your github account. A fork can be used to test out changes separately and then request to add those to the main repository as well!
🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
Create A New Branch: A branch is used to test new changes before they are merged with the stable master branch. You can create a new branch in the terminal. Make sure to name it descriptively!
📝 Make The Requested Changes
✅ Commit Your Changes: A Git commit is a change that is finalized and recorded in the branch.
🔀 Start a Pull Request(PR). There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also open a PR from the browser.

🏁 Done Ask in comments for a review :)

Please keep us updated

💬 🔔 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need it if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

### First Timers Only This issue is reserved for people who haven't contributed to our codebase before, or never contributed to Open Source. [About First Timers Only](https://www.firsttimersonly.com/). We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝 If you have contributed before, **consider leaving this one for someone new** and looking through our general [help wanted](https://github.com/lbryio/lbry-desktop/labels/help%20wanted) issues. Thanks! ### 🤔 What you will need to know. Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process. ### What is to be done?   Currently only the `Tip` button on the channel pages has a tooltip. ![no-tooltip](https://user-images.githubusercontent.com/34770591/80383402-25a72c80-88c1-11ea-9480-eabcbd49942c.gif) Having tooltips on the other buttons will improve consistency and also be helpful. #### :mag_right: Files To Look Into:  1. The `Tip` button, for reference. https://github.com/lbryio/lbry-desktop/blob/8b6c64441566f345cc9204d1906340526e741743/ui/page/channel/view.jsx#L203-L209 2. The `Follow/Unfollow` button. https://github.com/lbryio/lbry-desktop/blob/master/ui/component/subscribeButton/view.jsx 3. The `Share` button. https://github.com/lbryio/lbry-desktop/blob/master/ui/component/shareButton/view.jsx 4. The `Block` button. https://github.com/lbryio/lbry-desktop/blob/master/ui/component/blockButton/view.jsx ### 📋 Step by Step - [ ] :scroll: **Read The CONTRIBUTING File**: We welcome contributions from everyone, the [CONTRIBUTING](https://github.com/lbryio/lbry-desktop/blob/master/CONTRIBUTING.md) will help you get started. **NOTE**: Useful links: - - [Git Commands](https://www.siteground.com/tutorials/git/commands/) - - [Installation Instructions](https://github.com/lbryio/lbry-desktop#running-from-source) - [ ] **Fork This Repository**: A [fork](https://help.github.com/articles/fork-a-repo/) is a copy of this repository that is stored under your github account. A fork can be used to test out changes separately and then request to add those to the main repository as well! - [ ] :raising_hand: **Claim this issue**: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along! - [ ] **Create A New Branch**: A [branch](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-branches) is used to test new changes before they are merged with the stable `master` branch. You can create a new branch in the terminal. Make sure to name it descriptively! - [ ] :memo: **Make The Requested Changes** - [ ] :white_check_mark: **Commit Your Changes**: A Git [commit](https://help.github.com/en/desktop/contributing-to-projects/committing-and-reviewing-changes-to-your-project#about-commits) is a change that is finalized and recorded in the branch. - [ ] :twisted_rightwards_arrows: **Start a Pull Request(PR)**. There are two ways how you can start a pull request: 1. If you are familiar with the terminal or would like to learn it, [here is a great tutorial](https://egghead.io/series/how-to-contribute-to-an-open-source-project-on-github) on how to send a pull request using the terminal. 2. You can also [open a PR from the browser](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork). - [ ] 🏁 **Done** Ask in comments for a review :) ### Please keep us updated :speech_balloon: :bell: - We encourage contributors to be respectful to the community and provide an update **within a week** of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need it if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance! If this happens to you, don't sweat it! Grab another open issue. ### Is someone else already working on this? 🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it. 👥- **If someone seems stuck, offer them some help!** Otherwise, [take a look at some other issues you can help with](https://github.com/lbryio/lbry-desktop/labels/help%20wanted). Thanks! ### 🤔❓ Questions? Leave a comment below!

harshkhandeparkar commented

2020-04-27 16:32:16 +02:00

(Migrated from github.com)

Is this one fine for first-timers?

neb-b commented

2020-04-27 18:13:39 +02:00

(Migrated from github.com)

Yep!

calvincodes commented

2020-04-27 18:32:16 +02:00

(Migrated from github.com)

Hi! Can I work on this issue? Thanks.

harshkhandeparkar commented

2020-04-27 18:40:21 +02:00

(Migrated from github.com)

Sure. Go ahead.

harshkhandeparkar commented

2020-04-27 18:40:55 +02:00

(Migrated from github.com)

@seanyesmunt new contributor already 🚀!

@seanyesmunt new contributor already :rocket:!

harshkhandeparkar commented

2020-04-27 18:41:25 +02:00

(Migrated from github.com)

@calvincodes you can ask any difficulty here.

👍 1

calvincodes commented

2020-04-27 19:12:34 +02:00

(Migrated from github.com)

Thanks @HarshKhandeparkar. Sure, will do.

🚀 1

calvincodes commented

2020-04-28 05:31:39 +02:00

(Migrated from github.com)

@HarshKhandeparkar What should be the content of these messages?

harshkhandeparkar commented

2020-04-28 07:00:58 +02:00

(Migrated from github.com)

Language should be English. Content can be whatever you feel is Intuitive.

On Tue, 28 Apr, 2020, 9:01 AM Arpit Jain, notifications@github.com wrote:

@HarshKhandeparkar https://github.com/HarshKhandeparkar What should the
language/content of these messages be?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-desktop/issues/4085#issuecomment-620358778,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIJI5HZPWAZQNMTM4SAPUPTROZE2RANCNFSM4MR7HCUQ
.

Language should be English. Content can be whatever you feel is Intuitive. On Tue, 28 Apr, 2020, 9:01 AM Arpit Jain, <notifications@github.com> wrote: > @HarshKhandeparkar <https://github.com/HarshKhandeparkar> What should the > language/content of these messages be? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/lbryio/lbry-desktop/issues/4085#issuecomment-620358778>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AIJI5HZPWAZQNMTM4SAPUPTROZE2RANCNFSM4MR7HCUQ> > . >

👍 1