Video player does not work on iPad #4150

Closed
opened 2020-05-07 16:43:47 +02:00 by tzarebczan · 2 comments
tzarebczan commented 2020-05-07 16:43:47 +02:00 (Migrated from github.com)

Getting reports that our video player just shows a black screen on ipad
image1 (1)

Getting reports that our video player just shows a black screen on ipad ![image1 (1)](https://user-images.githubusercontent.com/8120721/81308252-8ec03a00-904f-11ea-999c-ac8ddc05ae0f.png)
jeffslofish commented 2020-05-16 05:40:44 +02:00 (Migrated from github.com)

It appears that both the native and videojs controls are hidden. I think we should show one or the other. I believe the video is not playing when you try to autoplay a non-muted video in iOS, so if the controls were there, the user could manually start the video.

If we want to show native controls, we need to add

html5: { nativeControlsForTouch: true, },
here: https://github.com/lbryio/lbry-desktop/blob/master/ui/component/viewers/videoViewer/internal/videojs.jsx#L79.

If we want to show the videojs controls, we need to unhide them here: https://github.com/lbryio/lbry-desktop/blob/master/ui/scss/component/_file-render.scss#L292

@seanyesmunt What do you think?

It appears that both the native and videojs controls are hidden. I think we should show one or the other. I believe the video is not playing when you try to autoplay a non-muted video in iOS, so if the controls were there, the user could manually start the video. If we want to show native controls, we need to add ` html5: { nativeControlsForTouch: true, }, ` here: https://github.com/lbryio/lbry-desktop/blob/master/ui/component/viewers/videoViewer/internal/videojs.jsx#L79. If we want to show the videojs controls, we need to unhide them here: https://github.com/lbryio/lbry-desktop/blob/master/ui/scss/component/_file-render.scss#L292 @seanyesmunt What do you think?
neb-b commented 2020-05-18 15:57:25 +02:00 (Migrated from github.com)

That sounds good. I don't see the video-js controls on my iPhone, maybe iPad doesn't show it's own native controls unless that flag is passed in?

That sounds good. I don't see the video-js controls on my iPhone, maybe iPad doesn't show it's own native controls unless that flag is passed in?
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#4150
No description provided.