Fix relative-date translation #4172

Merged

infinite-persistence merged 3 commits from fix-relative-date-translation into master

2020-05-11 20:54:06 +02:00

infinite-persistence commented

2020-05-11 10:29:55 +02:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: 4124

What is the current behavior?

The relative date of an item (e.g. "xxx hours ago") isn't shown consistently, language-wise.

What is the new behavior?

Fixes #4124. All relative dates (claims, comments) will now be consistently translated. However, they will remain as English until the translations updated all the new strings. See commit comments for more details.

Other information

There's no breakage, but today's code does now load an individual Channel's page. I've verified that it is not due to my changes.

## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: 4124 ## What is the current behavior? The relative date of an item (e.g. "xxx hours ago") isn't shown consistently, language-wise. ## What is the new behavior? Fixes #4124. All relative dates (claims, comments) will now be consistently translated. However, they will remain as English until the translations updated all the new strings. See commit comments for more details. ## Other information  There's no breakage, but today's code does now load an individual Channel's page. I've verified that it is not due to my changes.

tzarebczan commented

2020-05-11 15:16:47 +02:00

(Migrated from github.com)

Thanks for the PR! We'll get this reviewed soon.

Can we show you some appreciation for the contribution?

Also, please consider signing up for our dev mailing list at the bottom of lbry.tech!

Thanks for the PR! We'll get this reviewed soon. Can we show you some [appreciation](https://lbry.com/faq/appreciation) for the contribution? Also, please consider signing up for our dev mailing list at the bottom of lbry.tech!

neb-b (Migrated from github.com) requested changes 2020-05-11 15:52:39 +02:00