Developer menu item showing on all installs #428

Closed
opened 2017-08-03 17:34:42 +02:00 by kauffj · 12 comments
kauffj commented 2017-08-03 17:34:42 +02:00 (Migrated from github.com)

It should only be shown if development mode is enabled (possibly developer mode is enabled for all installs).

It should only be shown if development mode is enabled (possibly developer mode is enabled for all installs).
hackrush01 commented 2017-08-28 11:32:43 +02:00 (Migrated from github.com)

How does one enable developer mode explicitly?

How does one enable developer mode explicitly?
kauffj commented 2017-08-28 14:36:41 +02:00 (Migrated from github.com)

It looks like this is the check being used in most places:

lbry.getClientSetting("showDeveloperMenu")

It looks like this is the check being used in most places: ```lbry.getClientSetting("showDeveloperMenu")```
hackrush01 commented 2017-08-28 14:54:59 +02:00 (Migrated from github.com)

So should this be a setting in the Settings page to enable or disable the developer mode?

So should this be a setting in the `Settings` page to enable or disable the developer mode?
kauffj commented 2017-08-28 15:17:25 +02:00 (Migrated from github.com)

I think the setting for toggling developer mode can go away in favor of using process.env.NODE_ENV (which is already used in several places). I think we should retain the ability to set alternative search servers and move this into normal settings, at the bottom.

I think the setting for toggling developer mode can go away in favor of using `process.env.NODE_ENV` (which is already used in several places). I think we should retain the ability to set alternative search servers and move this into normal settings, at the bottom.
hackrush01 commented 2017-08-28 17:40:49 +02:00 (Migrated from github.com)

Ok, so what I understand is

  • Remove ui/js/page/developer.js
  • Remove the option for toggling dev mode(the devs would use keyboard shortcuts to open console and refresh app)
  • Remove force update
  • Keep alt search server stuff.
Ok, so what I understand is - [ ] Remove `ui/js/page/developer.js` - [ ] Remove the option for toggling dev mode(the devs would use keyboard shortcuts to open console and refresh app) - [ ] Remove force update - [ ] Keep alt search server stuff.
kauffj commented 2017-08-28 17:44:16 +02:00 (Migrated from github.com)

Correct except for #2. The dev mode would be toggled by setting an environment variable.

Correct except for #2. The dev mode would be toggled by setting an environment variable.
hackrush01 commented 2017-08-28 17:47:51 +02:00 (Migrated from github.com)

Gotcha. Thanks.

Gotcha. Thanks.
btzr-io commented 2017-11-12 21:20:04 +01:00 (Migrated from github.com)

is this still an issue?

is this still an issue?
tzarebczan commented 2017-11-12 21:30:45 +01:00 (Migrated from github.com)

The menu bar was reinstated in the last version, but requires pressing Alt on windows machines or mousing over the menu bar on Linux (not sure about Mac).

Sounds like there are some remaining issues which were discussed in the thread, so I'll leave it open for now.

The menu bar was reinstated in the last version, but requires pressing Alt on windows machines or mousing over the menu bar on Linux (not sure about Mac). Sounds like there are some remaining issues which were discussed in the thread, so I'll leave it open for now.
btzr-io commented 2017-11-12 21:41:10 +01:00 (Migrated from github.com)

Ok, win.setMenuBarVisibility(visible) only works for windows and linux

Ok, `win.setMenuBarVisibility(visible)` only works for windows and linux
liamcardenas commented 2017-12-15 03:39:32 +01:00 (Migrated from github.com)

@tzarebczan this is not happening for me in macOS
screen shot 2017-12-14 at 6 38 18 pm

can you check windows and if it doesn't show we should close this.

@tzarebczan this is not happening for me in macOS <img width="366" alt="screen shot 2017-12-14 at 6 38 18 pm" src="https://user-images.githubusercontent.com/5027235/34024257-05b41982-e0fe-11e7-9401-4659c82f052b.png"> can you check windows and if it doesn't show we should close this.
tzarebczan commented 2017-12-15 04:06:53 +01:00 (Migrated from github.com)

See my last comment - this was fixed a while ago by hiding the Dev menu by default, but I wasn't sure if we wanted a settings option/environmental variable somewhere to enable show by default.

But I'd say yes, let's close for now. The users that generally need to get there know how to. Can always pop it into a faq too.

See my last comment - this was fixed a while ago by hiding the Dev menu by default, but I wasn't sure if we wanted a settings option/environmental variable somewhere to enable show by default. But I'd say yes, let's close for now. The users that generally need to get there know how to. Can always pop it into a faq too.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#428
No description provided.