Show minimum LBC deposit amounts for Publish / Claims #439

2017-08-05T18:09:27+02:00

btzr-io commented

2017-08-05 18:09:27 +02:00

(Migrated from github.com)

Fixes

Show the minimum LBC deposit amounts for Publish / Claims

The App should either not allow something under 0.000097 or show what the minimum is.

Fix for https://github.com/lbryio/lbry-app/issues/432, https://github.com/lbryio/lbry-app/issues/440, https://github.com/lbryio/lbry-app/issues/441

Todo

Get fees ( dynamically ).
Better error message.
Display minimum deposit for claim.
Display minimum bid for channel creation.
Prevent negative value from inputs.

### Fixes Show the minimum LBC deposit amounts for Publish / Claims > The App should either not allow something under 0.000097 or show what the minimum is. Fix for https://github.com/lbryio/lbry-app/issues/432, https://github.com/lbryio/lbry-app/issues/440, https://github.com/lbryio/lbry-app/issues/441 ### Todo - [ ] Get fees ( dynamically ). - [x] Better error message. - [x] Display minimum deposit for claim. - [x] Display minimum bid for channel creation. - [x] Prevent negative value from inputs.

btzr-io commented

2017-08-06 01:32:02 +02:00

(Migrated from github.com)

![min-claim](https://user-images.githubusercontent.com/14793624/28999434-f98e1d58-7a03-11e7-81e0-0dcd48e1d2af.gif)

kauffj (Migrated from github.com) reviewed

2017-08-06 17:37:26 +02:00

kauffj (Migrated from github.com) left a comment

Great contribution @btzr-io! Some minor feedback on error text.

Also, blocking these from being bid is not something we want to do. It is actually a bug that they cannot be unbid.

Great contribution @btzr-io! Some minor feedback on error text. Also, blocking these from being bid is not something we want to do. It is actually a bug that they cannot be unbid.

ui/js/component/publishForm/internal/channelSection.jsx

					
				@ -54,2 +54,4 @@

				  handleCreateChannelClick(event) {

				    const min = this.minChannelBid();

"The minimum amount is ${this.minChannelBid()} credits."

ui/js/component/publishForm/view.jsx

It's actually a bug that these cannot be abandoned :/

ui/js/component/publishForm/view.jsx

					
				@ -301,8 +305,16 @@ class PublishForm extends React.PureComponent {

				  }

Use the same error text as above.

btzr-io (Migrated from github.com) reviewed

2017-08-06 18:21:26 +02:00

ui/js/component/publishForm/internal/channelSection.jsx

					
				@ -54,2 +54,4 @@

				  handleCreateChannelClick(event) {

				    const min = this.minChannelBid();

Ok, thanks, I'm not good with error messages 🙃

Ok, thanks, I'm not good with error messages :upside_down_face:

btzr-io commented

2017-08-07 01:08:20 +02:00

(Migrated from github.com)

@kauffj Are negatives value allowed for some reason? ^^

kauffj commented

2017-08-13 00:24:06 +02:00

(Migrated from github.com)

I merged this for the unused code it removed, but I did not keep the minimum checks. There is no intention for there to be minimums, and the minimums will be dropped when the corresponding bug in lbry is fixed.

I'd be open to ways we can better communicate that there is some small amount of a transaction that is unrecoverable.

I merged this for the unused code it removed, but I did not keep the minimum checks. There is no intention for there to be minimums, and the minimums will be dropped when the corresponding bug in lbry is fixed. I'd be open to ways we can better communicate that there is some small amount of a transaction that is unrecoverable.

👍 1