LBRYCommunity/lbry-desktop

Fork 0

Inputs allow negative value #441

New issue

Closed

opened 2017-08-06 04:26:17 +02:00 by btzr-io · 9 comments

btzr-io commented

2017-08-06 04:26:17 +02:00

(Migrated from github.com)

The Issue

The claim deposit input inside publish page allows a negative value.

Steps to reproduce

Open publish page
Go to Content URL > deposit
Add a negative value.

Expected behaviour

It should probably allow 0 or minimum but not negative.

Actual behaviour

A negative value it's assigned,

System Configuration

Configuration	Version
App	0.14.3
Daemon (lbrynet)	0.14.2
Wallet (lbryum)	3.1.4
Platform	Linux (Linux-4.10.0-28-generic-x86_64-with-elementary-0.4.1-loki)

Screenshots

## The Issue The claim deposit input inside `publish` page allows a negative value. ### Steps to reproduce 1. Open publish page 2. Go to Content URL > deposit 3. Add a negative value. ### Expected behaviour It should probably allow `0` or `minimum` but not negative. ### Actual behaviour A negative value it's assigned, ## System Configuration   Configuration | Version -- | -- App | 0.14.3 Daemon (lbrynet) | 0.14.2 Wallet (lbryum) | 3.1.4 Platform | Linux (Linux-4.10.0-28-generic-x86_64-with-elementary-0.4.1-loki) ## Screenshots  ![negative](https://user-images.githubusercontent.com/14793624/29000040-4ddc2b30-7a1c-11e7-8667-11319d807e00.gif)

btzr-io commented

2017-08-06 04:34:47 +02:00

(Migrated from github.com)

https://github.com/lbryio/lbry-app/issues/398

tzarebczan commented

2017-08-07 14:50:38 +02:00

(Migrated from github.com)

Don't think #398 has anything to do with this one.

👍 1

btzr-io commented

2017-08-08 04:03:22 +02:00

(Migrated from github.com)

ok, I was just pointing out a similar issue,
they are kind of related because both of them are: ux-issue

ok, I was just pointing out a similar issue, they are kind of related because both of them are: `ux-issue `

btzr-io commented

2017-08-08 04:04:21 +02:00

(Migrated from github.com)

Less then two. I understand that this is not critical issue. I think you can change it to something like "pending" instead of negative value.

> Less then two. I understand that this is not critical issue. I think you can change it to something like "pending" instead of negative value.

kauffj commented

2017-08-12 21:21:51 +02:00

(Migrated from github.com)

Fixed in Publish page, as well as in all LBC/USD hybrid inputs.

😕 1

btzr-io commented

2017-08-12 21:29:43 +02:00

(Migrated from github.com)

are you sure?? ^^ what about? -> #471

kauffj commented

2017-08-12 21:38:42 +02:00

(Migrated from github.com)

Merged #471.

👍 1

btzr-io commented

2017-08-12 21:40:39 +02:00

(Migrated from github.com)

Also I think maybe would be better to set the formFieldPrice default prop min to 0 🙃

Also I think maybe would be better to set the `formFieldPrice` default prop `min` to 0 :upside_down_face:

kauffj commented

2017-08-12 21:58:46 +02:00

(Migrated from github.com)

If themin isn't a multiple of step, Chrome has some undesirable behavior when using the arrows (e.g. it will step 5 down to 4.91, with min=0.01 and step=0.1).

If the`min` isn't a multiple of `step`, Chrome has some undesirable behavior when using the arrows (e.g. it will step 5 down to 4.91, with min=0.01 and step=0.1).

👍 1