LBRYCommunity/lbry-desktop

pop out player on scroll / Add button to pop out via floating player #4932

New issue

Open

opened 2020-10-22 16:47:45 +02:00 by tzarebczan · 6 comments

tzarebczan commented

2020-10-22 16:47:45 +02:00

(Migrated from github.com)

We removed the browser based pop-out button cause it would cause confusion between our pop out and the browser one, but now there's no way to force a pop out unless you navigate away.

Other suggestion would be to automatically pop out when scrolling down in comments (in both comment replies and original)

We removed the browser based pop-out button cause it would cause confusion between our pop out and the browser one, but now there's no way to force a pop out unless you navigate away. Other suggestion would be to automatically pop out when scrolling down in comments (in both comment replies and original)

DispatchCommit commented

2021-01-21 06:49:04 +01:00

(Migrated from github.com)

This could be done with an intersection observer

To detect when >X% of the player has passed the top of the viewport, then pop out
(and vice versa, pop in when scrolling back up far enough)

This could be done with an [intersection observer](https://developer.mozilla.org/en-US/docs/Web/API/Intersection_Observer_API) To detect when >X% of the player has passed the top of the viewport, then pop out (and vice versa, pop *in* when scrolling back up far enough)

Ruk33 commented

2021-02-09 14:25:22 +01:00

(Migrated from github.com)

Hello guys, I'll be working on this one.

Hello guys, I'll be working on this one.

Ruk33 commented

2021-02-09 16:27:11 +01:00

(Migrated from github.com)

Hello guys, is this ok?

https://user-images.githubusercontent.com/1719111/107385710-e6556f80-6ad1-11eb-8a50-8e875a044c40.mp4

Regards.

Hello guys, is this ok? https://user-images.githubusercontent.com/1719111/107385710-e6556f80-6ad1-11eb-8a50-8e875a044c40.mp4 Regards.

tzarebczan commented

2021-02-09 17:22:17 +01:00

(Migrated from github.com)

That looks great! I wonder if we should force the pop-out player to the right side so it doesn't take over the comment area? @seanyesmunt thoughts?

That looks great! I wonder if we should force the pop-out player to the right side so it doesn't take over the comment area? @seanyesmunt thoughts?

Ruk33 commented

2021-02-11 11:51:16 +01:00

(Migrated from github.com)

I have pushed a WIP branch in the meantime https://github.com/Ruk33/lbry-desktop/tree/issue-4932-floating-player-scroll. Not sure about a few implementation details though...

I have pushed a WIP branch in the meantime https://github.com/Ruk33/lbry-desktop/tree/issue-4932-floating-player-scroll. Not sure about a few implementation details though...

Ruk33 commented

2021-02-18 14:55:35 +01:00

(Migrated from github.com)

Hello guys, just following this thread up. Any other changes required or is this good? @tzarebczan @seanyesmunt . Regards!

Hello guys, just following this thread up. Any other changes required or is this good? @tzarebczan @seanyesmunt . Regards!

Sign in to join this conversation.

No labels

area: discovery

area: installer

area: livestream

area: performance

area: subscriptions

feature request

first-timers-only

good first issue

merge when green

needs: exploration

needs: grooming

needs: priority

needs: tech design

priority: blocker

priority: medium

protocol dependent

type: discussion

type: improvement

type: new feature

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#4932

No description provided.