LBRYCommunity/lbry-desktop

Fork 0

Airplay support MacOS / Chomecast support #508

New issue

Open

opened 2017-08-27 17:13:38 +02:00 by tumispro · 16 comments

tumispro commented

2017-08-27 17:13:38 +02:00

(Migrated from github.com)

I understand this is not at all a priority, but it would be really cool if Apple Airplay functionality could be added to the Mac app.
I understand an iOS app is underway as well, so native Airplay support on there is perhaps an option as well in the future :-)

I understand this is not at all a priority, but it would be really cool if Apple Airplay functionality could be added to the Mac app. I understand an iOS app is underway as well, so native Airplay support on there is perhaps an option as well in the future :-)

👍 1

tzarebczan commented

2017-09-12 21:33:18 +02:00

(Migrated from github.com)

Don't forget Chromecast support :)

👍 7

eriknelson commented

2017-09-17 03:57:24 +02:00

(Migrated from github.com)

+1,must have feature for me.

alyssaoc commented

2018-08-03 15:56:32 +02:00

(Migrated from github.com)

open new issue for exploration

neb-b commented

2018-09-02 02:35:03 +02:00

(Migrated from github.com)

Chromecast support seems like it should be possible. There is an issue to bake cast functionality directly into Eelectron, but it doesn't seem like that is going anywhere.

There are a couple options, https://github.com/thibauts/node-castv2-client, https://github.com/GPMDP/electron-chromecast

It looks like node-castv2 has more support, and there is an example electron application using it
https://github.com/annexare/Chromecast

Most likely it will only work for a few media types, but I think this will definitely be possible.

We probably won't add airplay support, this is baked into macOS so I'm not sure what this feature would consist of anyway.

Chromecast support seems like it should be possible. There is an [issue](https://github.com/electron/electron/issues/869) to bake cast functionality directly into Eelectron, but it doesn't seem like that is going anywhere. There are a couple options, https://github.com/thibauts/node-castv2-client, https://github.com/GPMDP/electron-chromecast It looks like `node-castv2` has more support, and there is an example electron application using it https://github.com/annexare/Chromecast Most likely it will only work for a few media types, but I think this will definitely be possible. We probably won't add airplay support, this is baked into macOS so I'm not sure what this feature would consist of anyway.

neb-b commented

2018-09-02 02:36:08 +02:00

(Migrated from github.com)

My recommendation is to use node-castv2 since there is an example application. We should be able to use that code without changing to much.

My recommendation is to use `node-castv2` since there is an example application. We should be able to use that code without changing to much.

tzarebczan commented

2019-03-16 23:55:25 +01:00

(Migrated from github.com)

More and moe folks asking about this...perfect for lbry.tv too.

neb-b commented

2019-09-30 04:05:47 +02:00

(Migrated from github.com)

We are now using video.js. This plugin should work:
https://github.com/silvermine/videojs-chromecast

We are now using video.js. This plugin should work: https://github.com/silvermine/videojs-chromecast

mikadoplus commented

2020-05-11 19:25:09 +02:00

(Migrated from github.com)

Hi, already someone working on this ? I could work on it if it's ok, even though it's not a top priority.

neb-b commented

2020-05-11 19:45:52 +02:00

(Migrated from github.com)

No one is working on this @mikadoplus. It's all yours! I'd love to have this in the app

mikadoplus commented

2020-05-11 20:08:26 +02:00

(Migrated from github.com)

Thanks @seanyesmunt, just not sure about Airplay, will continue to investigate on it, but Chromecast shouldn't be an issue. Let's dive into this ^^.

neb-b commented

2020-05-11 20:11:20 +02:00

(Migrated from github.com)

No worries, just ignore Airplay for now. Chromecast support can be added first.

👍 1 👎 1

kauffj commented

2020-05-11 20:23:00 +02:00

(Migrated from github.com)

You will be a hero to the community if you add this @mikadoplus! This is one of the most requested features we haven't had the bandwidth for yet

mikadoplus commented

2020-05-19 16:45:14 +02:00

(Migrated from github.com)

Just teasing a bit ...

Just teasing a bit ... <img width="1430" alt="cast_teasing" src="https://user-images.githubusercontent.com/53256355/82340920-157dfb00-99f0-11ea-8008-ea17a3808726.png">

👍 1

neb-b commented

2020-05-19 17:09:00 +02:00

(Migrated from github.com)

@mikadoplus Awesome!!

mikadoplus commented

2020-05-26 18:30:34 +02:00

(Migrated from github.com)

So in order to go further with this, I created a commit for this feature and the PR.

https://github.com/lbryio/lbry-desktop/pull/4252

There is free room for improvements, but let's see it as a start and see if everything works fine. Although I must say that in my local dev version of lbry I wasn't able to play any video since they are behind a localhost source. Nevertheless, with the web version based on CDN sources this works without any problem. (Maybe a Port Forwarding issue)

To be easier to maintain I decided to create a separated package based on videojs.

So in order to go further with this, I created a commit for this feature and the PR. https://github.com/lbryio/lbry-desktop/pull/4252 There is free room for improvements, but let's see it as a start and see if everything works fine. Although I must say that in my local dev version of lbry I wasn't able to play any video since they are behind a localhost source. Nevertheless, with the web version based on CDN sources this works without any problem. (Maybe a Port Forwarding issue) To be easier to maintain I decided to create a separated package based on videojs.

neb-b commented

2020-05-26 22:23:41 +02:00

(Migrated from github.com)

@mikadoplus can you create a PR with that commit so it's easier to see the diff?