Re-enable trackpad scrolling on the homepage #510

Closed
opened 2017-08-28 06:30:42 +02:00 by jsigwart · 6 comments
jsigwart commented 2017-08-28 06:30:42 +02:00 (Migrated from github.com)

The Issue

Prior to the navigation arrows on the home page, you could scroll the videos by swiping the trackpad.

Steps to reproduce

  1. Go to home page of the app
  2. Try to swipe on the trackpad to navigate

Expected behaviour

Tell us what should happen
Scroll through the videos by swiping on the trackpad instead of having to use the navigation arrows.

Actual behaviour

Tell us what happens instead
Swiping does not work.

System Configuration

Macintosh.

  • LBRY Daemon version: 0.14.2
  • LBRY App version: 0.14.3
  • LBRY Installation ID: 3.1.4
  • Operating system: Mac OS X 15.6.0

Anything Else

Screenshots

<!-- Thanks for reporting an issue to LBRY and helping us improve! To make it possible for us to help you, please fill out below information carefully. Before reporting any issues, please make sure that you're using the latest version. - App releases: https://github.com/lbryio/lbry-app/releases - Standalone daemon: https://github.com/lbryio/lbry/releases We are also available on Slack at https://slack.lbry.io --> ## The Issue Prior to the navigation arrows on the home page, you could scroll the videos by swiping the trackpad. ### Steps to reproduce 1. Go to home page of the app 2. Try to swipe on the trackpad to navigate 3. ### Expected behaviour Tell us what should happen Scroll through the videos by swiping on the trackpad instead of having to use the navigation arrows. ### Actual behaviour Tell us what happens instead Swiping does not work. ## System Configuration Macintosh. <!-- For the app, this info is in the About section at the bottom of the Help page. You can include a screenshot instead of typing it out --> <!-- For the daemon, run: curl 'http://localhost:5279' --data '{"method":"version"}' and include the full output --> - LBRY Daemon version: 0.14.2 - LBRY App version: 0.14.3 - LBRY Installation ID: 3.1.4 - Operating system: Mac OS X 15.6.0 ## Anything Else <!-- Include anything else that does not fit into the above sections --> ## Screenshots <!-- If a screenshot would help explain the bug, please include one or two here -->
hackrush01 commented 2017-08-28 06:36:02 +02:00 (Migrated from github.com)

This is the feature I would love to have back in the app. It saves a lot of
hassle.

-Regards
-Amit Tulshyan

On 28-Aug-2017 10:00 am, "jsigwart" notifications@github.com wrote:

The Issue

Prior to the navigation arrows on the home page, you could scroll the
videos by swiping the trackpad.
Steps to reproduce

  1. Go to home page of the app
  2. Try to swipe on the trackpad to navigate

Expected behaviour

Tell us what should happen
Scroll through the videos by swiping on the trackpad instead of having to
use the navigation arrows.
Actual behaviour

Tell us what happens instead
Swiping does not work.
System Configuration

Macintosh.

  • LBRY Daemon version: 0.14.2
  • LBRY App version: 0.14.3
  • LBRY Installation ID: 3.1.4
  • Operating system: Mac OS X 15.6.0

Anything Else Screenshots


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-app/issues/510, or mute the thread
https://github.com/notifications/unsubscribe-auth/AQxPZnw2eleLUbBEEWnXQCEvbJpB2ebZks5sckJ0gaJpZM4PEEYu
.

This is the feature I would love to have back in the app. It saves a lot of hassle. -Regards -Amit Tulshyan On 28-Aug-2017 10:00 am, "jsigwart" <notifications@github.com> wrote: > The Issue > > Prior to the navigation arrows on the home page, you could scroll the > videos by swiping the trackpad. > Steps to reproduce > > 1. Go to home page of the app > 2. Try to swipe on the trackpad to navigate > 3. > > Expected behaviour > > Tell us what should happen > Scroll through the videos by swiping on the trackpad instead of having to > use the navigation arrows. > Actual behaviour > > Tell us what happens instead > Swiping does not work. > System Configuration > > Macintosh. > > - LBRY Daemon version: 0.14.2 > - LBRY App version: 0.14.3 > - LBRY Installation ID: 3.1.4 > - Operating system: Mac OS X 15.6.0 > > Anything Else Screenshots > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/lbryio/lbry-app/issues/510>, or mute the thread > <https://github.com/notifications/unsubscribe-auth/AQxPZnw2eleLUbBEEWnXQCEvbJpB2ebZks5sckJ0gaJpZM4PEEYu> > . >
kauffj commented 2017-08-28 14:46:05 +02:00 (Migrated from github.com)

@hackrush01 I'm guessing this will require adding an explicit catch of the javascript event. But this would go nicely along with adding keyboard short cuts more generally.

How did this work previously? Did it scroll multiple rows at once? Just the top row?

@hackrush01 I'm guessing this will require adding an explicit catch of the javascript event. But this would go nicely along with adding keyboard short cuts more generally. How did this work previously? Did it scroll multiple rows at once? Just the top row?
hackrush01 commented 2017-08-28 15:09:42 +02:00 (Migrated from github.com)

@kauffj This "feature" was there in the app previously before the navigation arrows, so there was a scrollbar under each row, and each of them could be scrolled individually. I guess if need to have this feature back, we would need to re-enable scroll bars(in a hidden way maybe. I'm not sure if that's possible).

@kauffj This "feature" was there in the app previously before the navigation arrows, so there was a scrollbar under each row, and each of them could be scrolled individually. I guess if need to have this feature back, we would need to re-enable scroll bars(in a hidden way maybe. I'm not sure if that's possible).
liamcardenas commented 2017-12-15 03:50:16 +01:00 (Migrated from github.com)

I am closing this because this is encompassed by the homepage redesign: https://github.com/lbryio/lbry-app/issues/849

I am closing this because this is encompassed by the homepage redesign: https://github.com/lbryio/lbry-app/issues/849
tzarebczan commented 2018-04-26 16:01:05 +02:00 (Migrated from github.com)

Re-opening this because we still can't scroll horizontally in the re-design via trackpad/mouse.

Re-opening this because we still can't scroll horizontally in the re-design via trackpad/mouse.
neb-b commented 2019-01-07 17:44:18 +01:00 (Migrated from github.com)
Added in https://github.com/lbryio/lbry-desktop/pull/2164
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
LBRYCommunity/lbry-desktop#510
No description provided.