Links to comments don't always work #5161

New issue

Closed

opened 2020-12-10 14:01:28 +01:00 by infinite-persistence · 2 comments

infinite-persistence commented

2020-12-10 14:01:28 +01:00

(Migrated from github.com)

Normally, links to comments will bring you directly to that comment.
However, for this one, https://odysee.com/@lbry:3f/odysee:7?lc=29f439137dbdbc662453fe8cfd27969ed716627ddf08da6c0ebeb50ba34a86f9, it does not. It always go to the pinned comment instead. Scroll down to find it (it is still highlighted correctly).
The link to the comment right above this one works, though. And other deeper replies in the upper pages works as well.
So, I'm not sure what the faulty pattern is. Maybe something like "if the comment is on the 3rd reply level onwards, and is on "page 2" (infinite scroll) onwards in the comments section, the link does work"?

- Normally, links to comments will bring you directly to that comment. - However, for this one, https://odysee.com/@lbry:3f/odysee:7?lc=29f439137dbdbc662453fe8cfd27969ed716627ddf08da6c0ebeb50ba34a86f9, it does not. It always go to the pinned comment instead. Scroll down to find it (it is still highlighted correctly). - The link to the comment right above this one works, though. And other deeper replies in the upper pages works as well. - So, I'm not sure what the faulty pattern is. Maybe something like "if the comment is on the 3rd reply level onwards, _and_ is on "page 2" (infinite scroll) onwards in the comments section, the link does work"?

tzarebczan commented

2020-12-14 20:28:45 +01:00

(Migrated from github.com)

I've also noticed that videos autoplay sometimes when clicking from notifications - should disable that too.

Thanks for filing!

I've also noticed that videos autoplay sometimes when clicking from notifications - should disable that too. Thanks for filing!

infinite-persistence commented

2021-07-19 15:32:16 +02:00

(Migrated from github.com)

Close

This has been addressed while doing Comment Pagination.

If we end up reverting again in the future, the fix for this in the "fetch all" world is just to find the comment beyond the second level of replies.

## Close This has been addressed while doing Comment Pagination. If we end up reverting again in the future, the fix for this in the "fetch all" world is just to find the comment beyond the second level of replies.