LBRYCommunity/lbry-desktop
1
0
Fork 0
Code Issues 596 Pull requests 6 Projects Releases 238 Packages Wiki Activity

New repost flow #5167

Merged
jessopb merged 3 commits from repostFromSearchRebase into master 2020-12-16 16:32:30 +01:00
Conversation 0 Commits 3 Files changed 33 +940 -78
jessopb commented 2020-12-11 15:54:09 +01:00 (Migrated from github.com)
Copy link

rebased version

rebased version
neb-b (Migrated from github.com) reviewed 2020-12-11 15:54:09 +01:00
neb-b (Migrated from github.com) requested changes 2020-12-11 17:27:33 +01:00
static/app-strings.json
neb-b (Migrated from github.com) commented 2020-12-11 17:06:46 +01:00
Copy link

Unused strings need to be cleaned up

Unused strings need to be cleaned up
ui/component/claimPreview/view.jsx
neb-b (Migrated from github.com) commented 2020-12-11 17:27:03 +01:00
Copy link

Lets make these into their own components. claimPreview/internal/{mature-contnet, ...}

Lets make these into their own components. `claimPreview/internal/{mature-contnet, ...}`
ui/component/repostCreate/view.jsx
neb-b (Migrated from github.com) commented 2020-12-11 17:24:06 +01:00
Copy link

comment

comment
neb-b (Migrated from github.com) commented 2020-12-11 17:24:27 +01:00
Copy link

I think this should be Support instead of Stake

I think this should be `Support` instead of `Stake`
neb-b (Migrated from github.com) commented 2020-12-11 17:24:53 +01:00
Copy link

Move this somewhere inside the card or remove

Move this somewhere inside the card or remove
ui/component/searchTopClaim/index.js
neb-b (Migrated from github.com) commented 2020-12-11 17:23:37 +01:00
Copy link

You shouldn't need this comment

You shouldn't need this comment
neb-b (Migrated from github.com) commented 2020-12-11 17:23:44 +01:00
Copy link

extra comment

extra comment
ui/component/searchTopClaim/view.jsx
neb-b (Migrated from github.com) commented 2020-12-11 17:23:18 +01:00
Copy link

I'm not sure what this comment means

I'm not sure what this comment means
ui/component/searchTopClaim/view.jsx
@ -51,33 +60,68 @@ export default function SearchTopClaim(props: Props) {
}
neb-b (Migrated from github.com) commented 2020-12-11 17:22:18 +01:00
Copy link

Please use className="empty empty--centered" if we aren't using classnames or a js variable in the classname

Please use `className="empty empty--centered"` if we aren't using `classnames` or a js variable in the classname
ui/page/repost/view.jsx
neb-b (Migrated from github.com) commented 2020-12-11 17:18:05 +01:00
Copy link

Wrap this with <div className={classnames({"card--disabled": balance === 0 })}

Wrap this with `<div className={classnames({"card--disabled": balance === 0 })}`
neb-b (Migrated from github.com) commented 2020-12-11 17:19:07 +01:00
Copy link

You don't need to check for resolveUri since it will always exist

You don't need to check for `resolveUri` since it will always exist
neb-b (Migrated from github.com) commented 2020-12-11 17:20:52 +01:00
Copy link

I think this can just be from and to so the URL is more readable

I think this can just be `from` and `to` so the URL is more readable
ui/page/search/view.jsx
neb-b (Migrated from github.com) commented 2020-12-11 17:17:17 +01:00
Copy link

Not needed now but something I've been thinking about for a while is changing isSearching to return true if the lighthouse call hasn't returned yet or if the results from lighthouse aren't done resolving.

just FYI, should help with some UI flashing issues

Not needed now but something I've been thinking about for a while is changing `isSearching` to return `true` if the lighthouse call hasn't returned yet _or_ if the results from lighthouse aren't done resolving. just FYI, should help with some UI flashing issues
ui/page/top/index.js
neb-b (Migrated from github.com) commented 2020-12-11 17:15:55 +01:00
Copy link

I don't think you need this lint comment

I don't think you need this lint comment
ui/page/top/view.jsx
@ -24,2 +27,4 @@
name={channelActive ? `@${queryName}` : queryName}
defaultFreshness={FRESH_ALL}
defaultOrderBy={ORDER_BY_TOP}
meta={
neb-b (Migrated from github.com) commented 2020-12-11 17:10:21 +01:00
Copy link

Looking at the queryName line above... I think you can just do name={name}?

Looking at the `queryName` line above... I think you can just do `name={name}`?
ui/page/top/view.jsx
@ -26,0 +31,4 @@
<I18nMessage
tokens={{
repost: (
<Button
neb-b (Migrated from github.com) commented 2020-12-11 17:12:06 +01:00
Copy link

This doesn't need to be a new style. You can keep the header prop as it was, and pass the action text in with the meta prop.

https://github.com/lbryio/lbry-desktop/blob/master/ui/page/channelsFollowing/view.jsx#L35

This doesn't need to be a new style. You can keep the `header` prop as it was, and pass the action text in with the `meta` prop. https://github.com/lbryio/lbry-desktop/blob/master/ui/page/channelsFollowing/view.jsx#L35
neb-b (Migrated from github.com) commented 2020-12-11 17:15:23 +01:00
Copy link

meta={<I18nMessage>...

`meta={<I18nMessage>...`
ui/redux/selectors/search.js
@ -97,11 +104,13 @@ export const makeSelectWinningUriForQuery = (query: string) => {
neb-b (Migrated from github.com) commented 2020-12-11 17:09:05 +01:00
Copy link

This should only return pendingClaimUrl if it's effective amount is greater than claim1 and claim2

This should only return `pendingClaimUrl` if it's effective amount is greater than `claim1` and `claim2`
ui/scss/component/_claim-list.scss
neb-b (Migrated from github.com) commented 2020-12-11 17:14:47 +01:00
Copy link

This shouldn't be needed if you bring the help text into the card on the repost page (or remove it)

This shouldn't be needed if you bring the help text into the card on the repost page (or remove it)
ui/scss/component/_claim-list.scss
@ -135,2 +152,3 @@
width: 5rem;
min-height: 5rem;
width: 8rem;
}
neb-b (Migrated from github.com) commented 2020-12-11 17:13:55 +01:00
Copy link

Generally, I have been trying to follow this pattern

.class {
	style: value;

	&:psuedo {
		style: value;
	}

	@media (...) {
		style: value;
	}
}
Generally, I have been trying to follow this pattern ``` .class { style: value; &:psuedo { style: value; } @media (...) { style: value; } } ```
ui/scss/component/_claim-search.scss
@ -97,3 +97,15 @@
}
}
}
.claim-search__menu-group--between {
neb-b (Migrated from github.com) commented 2020-12-11 17:12:21 +01:00
Copy link

This shouldn't be needed if you use the meta prop

This shouldn't be needed if you use the `meta` prop
jessopb (Migrated from github.com) reviewed 2020-12-11 17:32:01 +01:00
ui/component/repostCreate/view.jsx
jessopb (Migrated from github.com) commented 2020-12-11 17:32:01 +01:00
Copy link

It was "Deposit"..

It was "Deposit"..
jessopb (Migrated from github.com) reviewed 2020-12-11 19:30:13 +01:00
ui/page/top/view.jsx
@ -24,2 +27,4 @@
name={channelActive ? `@${queryName}` : queryName}
defaultFreshness={FRESH_ALL}
defaultOrderBy={ORDER_BY_TOP}
meta={
jessopb (Migrated from github.com) commented 2020-12-11 19:30:13 +01:00
Copy link

Tried it, can't do it - it doesn't switch what claimListDiscover searches that way.

Tried it, can't do it - it doesn't switch what claimListDiscover searches that way.
jessopb (Migrated from github.com) reviewed 2020-12-11 22:26:17 +01:00
ui/redux/selectors/search.js
@ -97,11 +104,13 @@ export const makeSelectWinningUriForQuery = (query: string) => {
jessopb (Migrated from github.com) commented 2020-12-11 22:26:16 +01:00
Copy link

refactored to return the claim. was simpler than I thought.

refactored to return the claim. was simpler than I thought.
Sign in to join this conversation.
Reviewers
No reviewers
neb-b
Labels
Clear labels   
accessibility

   
app-parity

   
area: creator

   
area: daemon

   
area: design

   
area: devops

   
area: discovery

   
area: docs

   
area: installer

   
area: internal

   
area: livestream

   
area: performance

   
area: proposal

Work is part of a proposal

  
area: reposts

   
area: rewards

   
area: search

   
area: security

   
area: subscriptions

   
area: sync

   
area: ux

   
area: viewer

   
area: wallet

   
BEAMER

Beamer is waiting on you!

  
channel

   
comments

   
community PR

   
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
core team

   
css

   
dependencies

   
electron

   
Epic

   
feature request

   
first-timers-only

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
hub-dependent

   
icebox

Long-term storage

  
Invalid

   
level: 0

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
merge when green

   
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
notifications

   
odysee

   
on hold

Temporarily paused

  
playlists

   
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
protocol dependent

   
recsys

   
redesign

general redesign not prioritize for anyone release

  
regression

   
resilience

   
sdk dependent

Requires work on lbry-sdk repo

  
Tom's Wishlist

   
trending

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

  
windows
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#5167
No description provided.
Delete branch "repostFromSearchRebase"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?