#518 - Back Button - Does not ignore double clicks on destination buttons - LBRYCommunity/lbry-desktop

oakey22 commented

2017-08-30 23:56:45 +02:00

(Migrated from github.com)

Steps to reproduce

1.Click Settings Button (Top Right)
2.Click Home Button twice
3.Click Back

Expected behaviour

Should go back to the setting folder and not stay on the home screen.

Actual behaviour

Does not move off the home screen. I see this as a problem as i know a lot of people who will double click icons and buttons.

App	0.15.0rc2
0.15.1
3.1.6
gfugfqpsfpsewz@divermail.com

Linux (Linux-4.4.0-92-generic-x86_64-with-Ubuntu-16.04-xenial)

### Steps to reproduce 1.Click Settings Button (Top Right) 2.Click Home Button twice 3.Click Back ### Expected behaviour Should go back to the setting folder and not stay on the home screen. ### Actual behaviour Does not move off the home screen. I see this as a problem as i know a lot of people who will double click icons and buttons. App | 0.15.0rc2 -- | -- 0.15.1 3.1.6 gfugfqpsfpsewz@divermail.com Linux (Linux-4.4.0-92-generic-x86_64-with-Ubuntu-16.04-xenial)

tzarebczan commented

2017-08-31 00:16:00 +02:00

(Migrated from github.com)

If you click back again, does it go back to settings? I think it tracks each click, so it would need to take into account the scenario where the same button /action /screen is clicked twice.

oakey22 commented

2017-08-31 00:28:18 +02:00

(Migrated from github.com)

Yes it goes back if you double click, like you say it's tracking each click and does not account for a double click. I know my parents and a few of my friends always double click nearly everything lol.

MSFTserver commented

2017-08-31 03:37:17 +02:00

(Migrated from github.com)

yes youd have implement a check to see if there are two in a row that are the same and filter them out so its a list with no repeats

MSFTserver commented

2017-08-31 03:38:35 +02:00

(Migrated from github.com)

essentially double clicking logs it twice in the history so you have to press the back button twice to get passed the doubled up history

gyroninja commented

2017-08-31 03:51:08 +02:00

(Migrated from github.com)

I can not reproduce this bug on the latest version pushed to git.

👍 1

MSFTserver commented

2017-08-31 06:15:17 +02:00

(Migrated from github.com)

well thats where the issue arises @gyroninja simply press any menu button twice and youll have to press the back button twice or the first time it reloads the page again cause you clicked twice and it logged it to history twice

btzr-io commented

2017-08-31 06:23:00 +02:00

(Migrated from github.com)

@gyroninja @MSFTserver The new history logic don't allow history duplication ->
https://github.com/lbryio/lbry-app/blob/master/ui/js/reducers/navigation.js#L47

@gyroninja @MSFTserver The new history logic don't allow history duplication -> https://github.com/lbryio/lbry-app/blob/master/ui/js/reducers/navigation.js#L47

👍 1

btzr-io commented

2017-08-31 06:29:30 +02:00

(Migrated from github.com)

@tzarebczan I guess you can close this
unless someone can recreate the bug in master, but that should be impossible 😛

@tzarebczan I guess you can close this unless someone can recreate the bug in master, but that should be impossible :stuck_out_tongue:

👍 1

oakey22 commented

2017-08-31 10:55:41 +02:00

(Migrated from github.com)

I am getting this problem on the 0.15.0.rc2 version released yesterday. Has the fix been implemented since then?

👍 1