Portrait mode support for streaming videos in app #539

New issue

Closed

opened 2017-09-07 07:44:37 +02:00 by tzarebczan · 6 comments

tzarebczan commented

2017-09-07 07:44:37 +02:00

(Migrated from github.com)

The Issue

A user on Reddit noticed that his video, which was recorded in portrait mode, plays in landscape mode (rotated) via the app. The post is here: https://www.reddit.com/r/lbry/comments/6ykhxs/trying_to_upload_a_video_but_its_taking_forever/

Video is here: lbry://@pancake#c515f03fed88e677f28423ed175c8bbc046c8995/cauliflower

When opening the video from the downloads folder, it plays in portrait mode in my external player.

Steps to reproduce

Play lbry://@pancake#c515f03fed88e677f28423ed175c8bbc046c8995/cauliflower via LBRY app
Video plays in landscape mode, rotated
Play video in external player, plays correctly in portrait mode

Expected behaviour

Play in portrait mode via the app

Actual behaviour

Plays in landscape mode

System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

## The Issue A user on Reddit noticed that his video, which was recorded in portrait mode, plays in landscape mode (rotated) via the app. The post is here: https://www.reddit.com/r/lbry/comments/6ykhxs/trying_to_upload_a_video_but_its_taking_forever/ Video is here: lbry://@pancake#c515f03fed88e677f28423ed175c8bbc046c8995/cauliflower When opening the video from the downloads folder, it plays in portrait mode in my external player. ### Steps to reproduce 1. Play lbry://@pancake#c515f03fed88e677f28423ed175c8bbc046c8995/cauliflower via LBRY app 2. Video plays in landscape mode, rotated 3. Play video in external player, plays correctly in portrait mode ### Expected behaviour Play in portrait mode via the app ### Actual behaviour Plays in landscape mode ## System Configuration   - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else  ## Screenshots

kauffj commented

2017-09-12 15:25:40 +02:00

(Migrated from github.com)

@tzarebczan does this video play in the proper orientation when downloaded?

tzarebczan commented

2017-09-12 15:43:24 +02:00

(Migrated from github.com)

Yep, that's mentioned in the issue.

btzr-io commented

2017-09-14 07:28:29 +02:00

(Migrated from github.com)

Simple test

Just using the video element ( not render-media )

Not sure what's the issue, but seems to come from render-media,
I guess some how skips reading the Rotation tag from metadata...

Rotation

This data is used by browsers such as Chrome and Safari and by video players like VLC and QuickTime to display the video the way it was shot: portrait or landscape.

https://addpipe.com/blog/mp4-rotation-metadata-in-mobile-video-files/

Debug

exiftool -Rotation test.mp4
Rotation                        : 90

### Simple test Just using the video element ( not `render-media` ) <img height=275 src="https://user-images.githubusercontent.com/14793624/30413360-c16eaeb0-98da-11e7-8bb1-07cd872d7d5d.jpeg" /> Not sure what's the issue, but seems to come from `render-media`, I guess some how skips reading the `Rotation` tag from metadata... ### Rotation > This data is used by browsers such as Chrome and Safari and by video players like VLC and QuickTime to display the video the way it was shot: portrait or landscape. https://addpipe.com/blog/mp4-rotation-metadata-in-mobile-video-files/ ### Debug ``` exiftool -Rotation test.mp4 Rotation : 90 ```

btzr-io commented

2017-09-14 08:03:41 +02:00

(Migrated from github.com)