Bind enter key press to form submission as appropriate #542

Closed
opened 2017-09-08 18:10:24 +02:00 by tzarebczan · 3 comments
tzarebczan commented 2017-09-08 18:10:24 +02:00 (Migrated from github.com)

The Issue

If you try to use the Enter key to send credits on the Send screen or send an invite on the Invites screen, the page reloads and nothing happens

Steps to reproduce

  1. Go to Send screen, enter amount and address, press Enter
  2. Go to invite screen, enter email to invite, press Enter

Expected behaviour

Enter key should be allowed to confirm action

Actual behaviour

Enter key refreshes page.

System Configuration

  • LBRY Daemon version: 0.15.1
  • LBRY App version: 0.15.1
  • LBRY Installation ID:
  • Operating system: Windows

Anything Else

Screenshots

<!-- Thanks for reporting an issue to LBRY and helping us improve! To make it possible for us to help you, please fill out below information carefully. Before reporting any issues, please make sure that you're using the latest version. - App releases: https://github.com/lbryio/lbry-app/releases - Standalone daemon: https://github.com/lbryio/lbry/releases We are also available on Slack at https://slack.lbry.io --> ## The Issue If you try to use the Enter key to send credits on the Send screen or send an invite on the Invites screen, the page reloads and nothing happens ### Steps to reproduce 1. Go to Send screen, enter amount and address, press Enter 2. Go to invite screen, enter email to invite, press Enter 3. ### Expected behaviour Enter key should be allowed to confirm action ### Actual behaviour Enter key refreshes page. ## System Configuration <!-- For the app, this info is in the About section at the bottom of the Help page. You can include a screenshot instead of typing it out --> <!-- For the daemon, run: curl 'http://localhost:5279' --data '{"method":"version"}' and include the full output --> - LBRY Daemon version: 0.15.1 - LBRY App version: 0.15.1 - LBRY Installation ID: - Operating system: Windows ## Anything Else <!-- Include anything else that does not fit into the above sections --> ## Screenshots <!-- If a screenshot would help explain the bug, please include one or two here -->
kauffj commented 2017-09-08 19:48:20 +02:00 (Migrated from github.com)

@tzarebczan re-titled to the solution I'd like to see.

@tzarebczan re-titled to the solution I'd like to see.
btzr-io commented 2017-09-11 04:12:43 +02:00 (Migrated from github.com)

should all forms have this behavior ( publish form... ) ?

should all forms have this behavior ( `publish form...` ) ?
kauffj commented 2017-09-11 18:54:59 +02:00 (Migrated from github.com)

Publish probably shouldn't?

(It should only be happening when an input or label is not focused, regardless)

Publish probably shouldn't? (It should only be happening when an input or label is not focused, regardless)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#542
No description provided.