LBRYCommunity/lbry-desktop

Fork 0

Date is Americanised #546

New issue

Closed

opened 2017-09-10 06:11:01 +02:00 by oakey22 · 13 comments

oakey22 commented

2017-09-10 06:11:01 +02:00

(Migrated from github.com)

The Issue

Steps to reproduce

Click on any thumbnail on the main screen
2.look at the "Published on" date

Expected behaviour

I am from the UK and we have our date format DD-MM-YYYY so i would expect to have an option to specify where you are from or choose the format and this alters. Maybe have this in the settings.

Actual behaviour

Date is MM-DD-YYYY, as seen in the picture this can be misleading and confusing for days below the 13th.

Anything Else

App	0.15.1
0.15.2
3.1.6
gfugfqpsfpsewz@divermail.com

Linux (Linux-4.4.0-93-generic-x86_64-with-Ubuntu-16.04-xenial)

Screenshots

https://spee.ch/8afeb8a00bf3c13d0e63e660d6028e49728a4a27/lbry-date.jpg

## The Issue ### Steps to reproduce 1. Click on any thumbnail on the main screen 2.look at the "Published on" date ### Expected behaviour I am from the UK and we have our date format DD-MM-YYYY so i would expect to have an option to specify where you are from or choose the format and this alters. Maybe have this in the settings. ### Actual behaviour Date is MM-DD-YYYY, as seen in the picture this can be misleading and confusing for days below the 13th. ## Anything Else  App | 0.15.1 -- | -- 0.15.2 3.1.6 gfugfqpsfpsewz@divermail.com Linux (Linux-4.4.0-93-generic-x86_64-with-Ubuntu-16.04-xenial) ## Screenshots https://spee.ch/8afeb8a00bf3c13d0e63e660d6028e49728a4a27/lbry-date.jpg

👍 1

btzr-io commented

2017-09-10 06:32:01 +02:00

(Migrated from github.com)

Looks like a simple fix -> date.toLocaleString('en-GB')
The problem would be to implement the ui / ux for this ^

Looks like a simple fix -> `date.toLocaleString('en-GB')` The problem would be to implement the ui / ux for this ^

btzr-io commented

2017-09-10 06:37:24 +02:00

(Migrated from github.com)

i would expect to have an option to specify where you are from or choose the format and this alters. Maybe have this in the settings.

maybe something like this? -> window.navigator.language or app.getLocale()

> i would expect to have an option to specify where you are from or choose the format and this alters. Maybe have this in the settings. maybe something like this? -> `window.navigator.language` or `app.getLocale()`

btzr-io commented

2017-09-10 06:52:22 +02:00

(Migrated from github.com)

@oakey22 can you open Developer Tools: ctrl + shift + I
and run this in the console? -> app.i18n.getLocale()

@oakey22 can you open Developer Tools: ` ctrl + shift + I ` and run this in the console? -> `app.i18n.getLocale()`

oakey22 commented

2017-09-10 18:27:15 +02:00

(Migrated from github.com)

I get this when ran in console

app.i18n.getLocale()
"en"

I get this when ran in console ``` app.i18n.getLocale() "en" ```

👍 1

oakey22 commented

2017-09-10 18:27:58 +02:00

(Migrated from github.com)

and

window.navigator.language "en-US"

and `window.navigator.language "en-US"`

👍 1

btzr-io commented

2017-09-11 04:04:17 +02:00

(Migrated from github.com)

Oh yeah, there is only one language / locale supported at the moment -> en-US 😛
until that's fixed I guess this is the only possible solution for now:

Have an option to specify where you are from or choose the format and this alters.

Oh yeah, there is only one language / locale supported at the moment -> `en-US` :stuck_out_tongue: until that's fixed I guess this is the only possible solution for now: > Have an option to specify where you are from or choose the format and this alters.

liamcardenas commented

2017-12-15 03:46:10 +01:00

(Migrated from github.com)

@kauffj do you know if https://github.com/lbryio/lbry-app/issues/538 will fix this? if so, I will close this one.

kauffj commented

2017-12-15 22:51:36 +01:00

(Migrated from github.com)

@liamcardenas it will not. <DateTime> would need to be internationalized. It is, however, basically already set up to do so.

@liamcardenas it will not. `<DateTime>` would need to be internationalized. It is, however, basically already set up to do so.

miikkatu commented

2018-02-05 18:05:35 +01:00

(Migrated from github.com)

Is this fixed already, maybe as a side effect of some other change? For me, the date is shown like this: "Published on January 25, 2018". Not like in the screenshot of this issue.

tzarebczan commented

2018-02-05 19:10:00 +01:00

(Migrated from github.com)

@oakey22 can you share an updated screenshot how it looks in the latest version. I tried changing my regional settings but it still shows "February x, 2018" - wouldn't that be correct for all region formats?

miikkatu commented

2018-02-05 20:13:48 +01:00

(Migrated from github.com)

0.20.0

0.20.0 <img width="478" alt="date" src="https://user-images.githubusercontent.com/16205520/35823774-5bcadefc-0ab9-11e8-86b4-98c82c52aa41.png">

oakey22 commented

2018-02-07 16:56:38 +01:00

(Migrated from github.com)

Working for me now, thanks guys

says December 17th 2017

Working for me now, thanks guys says December 17th 2017

tzarebczan commented

2018-02-07 21:27:39 +01:00

(Migrated from github.com)

Going to close this, thanks for confirming @oakey22 !

@liamcardenas, please open a new issue for the internationalization convo if you feel its warranted.

Going to close this, thanks for confirming @oakey22 ! @liamcardenas, please open a new issue for the <DateTime> internationalization convo if you feel its warranted.