Annoying modal popups #551

New issue

Closed

opened 2017-09-11 04:46:59 +02:00 by btzr-io · 5 comments

btzr-io commented

2017-09-11 04:46:59 +02:00

(Migrated from github.com)

The Issue

There are some annoying and unnecessary popups inside the app.
Most of them are errors badly handled.

Steps to reproduce

If you have an empty balance and go to walletSend
a popup it's shown, but this is annoying and don't prevent the user of submitting the form.
If you try to send a higher value than your current balance an other popup it's shown, it should display the error below the input or don't allow -> value > balance .

Expected behaviour

A simple example of empty-states:

A list that doesn’t contain any items, or a search that doesn’t display any results, are examples of empty states. Although these states aren’t typical, they should be designed to prevent user confusion.

Reference

Please see this for reference:
https://material.io/guidelines/patterns/empty-states.html#
https://material.io/guidelines/patterns/errors.html#errors-user-input-errors

## The Issue There are some annoying and unnecessary popups inside the app. Most of them are errors badly handled. ### Steps to reproduce 1. If you have an empty balance and go to `walletSend` a popup it's shown, but this is annoying and don't prevent the user of submitting the form. 2. If you try to send a higher value than your current balance an other popup it's shown, it should display the error below the input or don't allow -> `value > balance` . ### Expected behaviour A simple example of empty-states: ![image](https://user-images.githubusercontent.com/14793624/30256765-468444e8-966a-11e7-83f8-59cad6dae75c.png) > A list that doesn’t contain any items, or a search that doesn’t display any results, are examples of empty states. Although these states aren’t typical, they should be designed to prevent user confusion. ### Reference Please see this for reference: https://material.io/guidelines/patterns/empty-states.html# https://material.io/guidelines/patterns/errors.html#errors-user-input-errors

btzr-io commented

2017-09-11 04:47:25 +02:00

(Migrated from github.com)

Split from -> https://github.com/lbryio/lbry-app/issues/531

btzr-io commented

2017-09-14 03:29:35 +02:00

(Migrated from github.com)

Here is another one, fixed in #550 -> 75417949122d1f6078357f290c95441ecfca3761

Here is another one, fixed in #550 -> 75417949122d1f6078357f290c95441ecfca3761 ![missign_parameters](https://user-images.githubusercontent.com/14793624/30408104-da50581e-98b9-11e7-8255-ae9fdf06d153.jpeg)

liamcardenas commented

2017-11-20 21:30:56 +01:00

(Migrated from github.com)

@btzr-io hey great work identifying this, what are the next steps for eliminating these modals?

btzr-io commented

2017-11-22 03:00:06 +01:00

(Migrated from github.com)

@liamcardenas Hi, first we would need to create an EmptyState component / layout:

The most basic empty state displays a non-interactive image and a text tagline.

For the image probably use some basic illustrations or just icons...

This was intended to be part of the material-design refactoring / improvement,
but now that the app is moving towards @nizuka01 design maybe look for other alternatives?

Anyway most of this errors come from: https://github.com/lbryio/lbry-app/issues/564,
so it should be better to handle this one first ^

https://material.io/guidelines/patterns/empty-states.html#

@liamcardenas Hi, first we would need to create an `EmptyState` component / layout: > The most basic empty state displays a non-interactive image and a text tagline. For the image probably use some basic illustrations or just icons... This was intended to be part of the `material-design` refactoring / improvement, but now that the app is moving towards @nizuka01 design maybe look for other alternatives? Anyway most of this errors come from: https://github.com/lbryio/lbry-app/issues/564, so it should be better to handle this one first ^ https://material.io/guidelines/patterns/empty-states.html#

alyssaoc commented

2018-10-09 19:07:49 +02:00

(Migrated from github.com)

most of these are fixed, please open new issues for specific modals