Markdown: Lists in Comments not rendered correctly #5560

Closed
opened 2021-02-22 07:05:30 +01:00 by infinite-persistence · 0 comments
infinite-persistence commented 2021-02-22 07:05:30 +01:00 (Migrated from github.com)

Issues

The following markdown...

Hello
* Bullet 1
* Bullet 2
    * Sub-bullet 1
    * Sub-bullet 2

... yields a correct-looking Post ....
image

... but incorrect Comment:
image

It's either our CSS problem, or might be related to https://github.com/remarkjs/remark/issues/517, which the fix requires an upgrade to remark v13 (we are currently on v8).
- v13 introduces a breaking change, and all plugins need to be tweaked.
- remark-attr, which we currently use, hasn't been updated yet (https://github.com/arobase-che/remark-attr/issues/22) so we can't go to v13.
- Going to v13 also seems to require some rework in remark-lbry.

(didn't use hyperlinks above as I didn't want to pollute their repo with "mentions")

## Issues The following markdown... ``` Hello * Bullet 1 * Bullet 2 * Sub-bullet 1 * Sub-bullet 2 ``` ... yields a correct-looking Post .... ![image](https://user-images.githubusercontent.com/64950861/108665591-3b50a700-7510-11eb-992e-547b5537b661.png) ... but incorrect Comment: ![image](https://user-images.githubusercontent.com/64950861/108665738-9a162080-7510-11eb-8ca3-8370e5099958.png) ## Potentially related It's either our CSS problem, or might be related to `https://github.com/remarkjs/remark/issues/517`, which the fix requires an upgrade to `remark v13` (we are currently on `v8`). - `v13` introduces a breaking change, and all plugins need to be tweaked. - `remark-attr`, which we currently use, hasn't been updated yet (`https://github.com/arobase-che/remark-attr/issues/22`) so we can't go to `v13`. - Going to `v13` also seems to require some rework in `remark-lbry`. (_didn't use hyperlinks above as I didn't want to pollute their repo with "mentions"_)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
LBRYCommunity/lbry-desktop#5560
No description provided.