page: buy: filter out deleted countries (fixes #5397) #5791

Merged

xdevs23 merged 1 commit from bugfix/5397 into odysee

2021-04-01 00:32:23 +02:00

xdevs23 commented

2021-03-28 21:53:45 +02:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: #5397

What is the current behavior?

Shows "German Democratic Republic":

What is the new behavior?

Does not show "German Democratic Republic":

Other information

While it does fix #5397 it does not remove entries like "USSR", "European Union" etc.
These probably need to be marked as "deleted" in https://github.com/OpenBookPrices/country-data/blob/master/data/countries.json and/or 011dbb6658/data/deleted_countries.csv

## PR Checklist Please check all that apply to this PR using "x": - [X] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [X] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [X] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #5397 ## What is the current behavior? Shows "German Democratic Republic": ![image](https://user-images.githubusercontent.com/6959245/112765929-bfb2b000-900f-11eb-82b3-8465d6eb8348.png) ## What is the new behavior? Does not show "German Democratic Republic": ![image](https://user-images.githubusercontent.com/6959245/112765981-030d1e80-9010-11eb-914c-e177a7424b58.png) ## Other information While it does fix #5397 it does not remove entries like "USSR", "European Union" etc. These probably need to be marked as "deleted" in https://github.com/OpenBookPrices/country-data/blob/master/data/countries.json and/or https://github.com/OpenBookPrices/country-data/blob/011dbb6658b0df5a36690af7086baa3e5c20c30c/data/deleted_countries.csv

tzarebczan commented

2021-03-30 18:41:57 +02:00

(Migrated from github.com)

Thank you for the PR, we'll get a review on this soon!

xdevs23 commented

2021-03-30 19:22:01 +02:00

(Migrated from github.com)

You're welcome! I've cherry-picked my change on top of the new HEAD of odysee to prevent the merge conflicts.

You're welcome! I've cherry-picked my change on top of the new `HEAD` of `odysee` to prevent the merge conflicts.