Feat publish replays on master #5863

Merged
jessopb merged 3 commits from feat-publishReplays-master2 into master 2021-04-14 06:06:11 +02:00
jessopb commented 2021-04-11 05:35:08 +02:00 (Migrated from github.com)
No description provided.
neb-b (Migrated from github.com) requested changes 2021-04-12 22:32:23 +02:00
neb-b (Migrated from github.com) left a comment

Few comments, nothing major

Few comments, nothing major
@ -121,6 +198,10 @@ function PublishFile(props: Props) {
updatePublishForm({ fileDur: duration, fileSize: size, fileVid: isvid });
}
neb-b (Migrated from github.com) commented 2021-04-12 22:28:01 +02:00

still unsure why this is needed

still unsure why this is needed
neb-b (Migrated from github.com) commented 2021-04-12 22:28:44 +02:00

This could cause issues since livestreamData isn't passed to the effect

This could cause issues since `livestreamData` isn't passed to the effect
@ -181,0 +248,4 @@
setSignedMessage(data);
})
.catch((error) => {
setSignedMessage({ signature: null, signing_ts: null });
neb-b (Migrated from github.com) commented 2021-04-12 22:31:38 +02:00

this shouldn't need the $FlowFixMe comment and also remove the bitwave comment

this shouldn't need the `$FlowFixMe` comment and also remove the bitwave comment
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#5863
No description provided.