Video shortcut issues #5865

New issue

Open

opened 2021-04-11 15:09:17 +02:00 by infinite-persistence · 1 comment

infinite-persistence commented

2021-04-11 15:09:17 +02:00

(Migrated from github.com)

Pressing "arrow down" lowers the volume and scrolls the page. It should only lower the volume if the video is in focus, and only scroll the page if the video is not in focus.
- Related: 4162 Spacebar on non-video pages should page forward, not be consumed.
Shortcut-handling should take ctrl/shift/alt into account -- I couldn't do a Ctrl+F on Odysee to find a word in the comments section, because that got absorbed by the "fullscreen (f)" shortcut.
- Fixed by #5874
We should update the Mobile UI's double-tap action to seek +/-5s instead of +/-10s, to match the recent change to the "left/right arrow" shortcut.
- Will be closed by #5952

- [ ] Pressing "arrow down" lowers the volume _and_ scrolls the page. It should only lower the volume if the video is in focus, and only scroll the page if the video is not in focus. - <img src="https://user-images.githubusercontent.com/64950861/126923426-1a8ba4ac-fc87-41a1-97f5-b806a64d79cc.png" width="600"> - _Related: `4162 Spacebar on non-video pages should page forward, not be consumed.`_ - [x] Shortcut-handling should take `ctrl/shift/alt into` account -- I couldn't do a Ctrl+F on Odysee to find a word in the comments section, because that got absorbed by the "fullscreen (f)" shortcut. - _Fixed by #5874_ - [x] We should update the Mobile UI's double-tap action to seek +/-5s instead of +/-10s, to match the recent change to the "left/right arrow" shortcut. - _Will be closed by #5952_

👍 2

infinite-persistence commented

2021-05-31 07:54:38 +02:00

(Migrated from github.com)

Hi @DispatchCommit, I think the last remaining task above and it's "related" issue requires the same solution. That involves some refactoring, and it reminded me of this:

Way down the road I want to pull out the key event listeners to replace with more modern javascript methods like keyCode instead of using character codes. Though that's a larger refactor as well due to the amount of event listeners.

Should I assign to you instead so that it gets covered together?

Hi @DispatchCommit, I think the last remaining task above and it's "related" issue requires the same solution. That involves some refactoring, and it reminded me of this: > _Way down the road I want to pull out the key event listeners to replace with more modern javascript methods like keyCode instead of using character codes. Though that's a larger refactor as well due to the amount of event listeners._ Should I assign to you instead so that it gets covered together?