Re-add ability to export transactions #5899

Merged

infinite-persistence merged 5 commits from ip/export-transactions into master

2021-04-23 18:10:38 +02:00

infinite-persistence commented

2021-04-16 15:00:22 +02:00

(Migrated from github.com)

Issue

Closes #4793 Export Wallet History For Taxation Purposes

Requires lbry-redux update

Screenshots

Start:
Fetching:
In the unlikely-event that the fetched data couldn't be parsed:
Fetched and file is ready:

## Issue Closes #4793 [Export Wallet History For Taxation Purposes](https://github.com/lbryio/lbry-desktop/issues/4793) _Requires lbry-redux update_ ## Screenshots - Start: - ![image](https://user-images.githubusercontent.com/64950861/115115746-a70f3780-9fc8-11eb-9321-f59e868cd4cc.png) - Fetching: - ![image](https://user-images.githubusercontent.com/64950861/115115660-2fd9a380-9fc8-11eb-83c9-e3dfaa584e43.png) - In the unlikely-event that the fetched data couldn't be parsed: - ![image](https://user-images.githubusercontent.com/64950861/115115641-1df80080-9fc8-11eb-92e6-222119f0c9d7.png) - Fetched and file is ready: - ![image](https://user-images.githubusercontent.com/64950861/115115845-33215f00-9fc9-11eb-841d-a1f902b58146.png)

tzarebczan commented

2021-04-19 22:33:50 +02:00

(Migrated from github.com)

Took about a minute on my wallet, will try some other large ones. Not bad...

I noticed support_list is called - is that data used anywhere? we shouldn't need anything outside of transaction list.

99K may be too small for some of the larger creators, so let's add another 9. We'll deal with performance issues/run manually for others as needed.

Took about a minute on my wallet, will try some other large ones. Not bad... I noticed support_list is called - is that data used anywhere? we shouldn't need anything outside of transaction list. 99K may be too small for some of the larger creators, so let's add another 9. We'll deal with performance issues/run manually for others as needed.

infinite-persistence commented

2021-04-20 04:33:40 +02:00

(Migrated from github.com)

I noticed support_list is called - is that data used anywhere? we shouldn't need anything outside of transaction list.

Wanted to ask that as well. @seanyesmunt, safe to remove doFetchSupports?

export function doFetchTransactions(page = 1, pageSize = 99999) {
  return dispatch => {
    dispatch(doFetchSupports());   // <---- ??
    dispatch({
      type: ACTIONS.FETCH_TRANSACTIONS_STARTED,
    });

    Lbry.transaction_list({ page, page_size: pageSize }).then(result => {
      dispatch({
        type: ACTIONS.FETCH_TRANSACTIONS_COMPLETED,
        data: {
          transactions: result.items,
        },
      });
    });
  };
}

> _I noticed support_list is called - is that data used anywhere? we shouldn't need anything outside of transaction list._ Wanted to ask that as well. @seanyesmunt, safe to remove `doFetchSupports`? ```javascript export function doFetchTransactions(page = 1, pageSize = 99999) { return dispatch => { dispatch(doFetchSupports()); // <---- ?? dispatch({ type: ACTIONS.FETCH_TRANSACTIONS_STARTED, }); Lbry.transaction_list({ page, page_size: pageSize }).then(result => { dispatch({ type: ACTIONS.FETCH_TRANSACTIONS_COMPLETED, data: { transactions: result.items, }, }); }); }; } ```

infinite-persistence commented

2021-04-20 04:39:24 +02:00

(Migrated from github.com)

Took about a minute on my wallet, will try some other large ones. Not bad...

Pondering if we need to add notification (desktop) or toast (web) for "Transactions file ready for download".
- Notifications Page would be better, but not available for Desktop/non-signed in users
"Fetching data..." would then need to be something like "Fetching data; check back here later".

> _Took about a minute on my wallet, will try some other large ones. Not bad..._ - Pondering if we need to add notification (desktop) or toast (web) for "Transactions file ready for download". - Notifications Page would be better, but not available for Desktop/non-signed in users - "Fetching data..." would then need to be something like "Fetching data; check back here later".

infinite-persistence commented

2021-04-20 05:02:33 +02:00

(Migrated from github.com)

UPDATE