Fast actions will often be undone when there's a background update #5931

New issue

Open

opened 2021-04-22 12:53:08 +02:00 by infinite-persistence · 4 comments

infinite-persistence commented

2021-04-22 12:53:08 +02:00

(Migrated from github.com)

Impacted areas:

/$/settings/block_and_mute
- If you have a huge list of muted channels, and you try to unmute them one by one in that page, you'll occasionally see an entry that you've just unmuted became muted again (the button updated).
Manage Tags
- If you add or remove tags at a certain pace, you'll see tags appear/disappear (opposite of what you just did) on the screen. Hard to reproduce, but will happen.
- Also, if keep clicking on the added tags to remove them, you'll end up with duplicates. The duplicates aren't really in the wallet, it's just in the GUI, so a reload usually fixes it.
Past Swaps
- Occasionally, you'll see an entry that you just removed 0.5s ago reappear because the wallet updated in the background.

There's potentially more.

Changing to a "edit, then press Save to finalize" model is one way to solve this, but not necessarily the best.

Impacted areas: - [ ] **/$/settings/block_and_mute** - If you have a huge list of muted channels, and you try to unmute them one by one in that page, you'll occasionally see an entry that you've just unmuted became muted again (the button updated). - [ ] **Manage Tags** - If you add or remove tags at a certain pace, you'll see tags appear/disappear (opposite of what you just did) on the screen. Hard to reproduce, but will happen. - Also, if keep clicking on the added tags to remove them, you'll end up with duplicates. The duplicates aren't really in the wallet, it's just in the GUI, so a reload usually fixes it. - ![image](https://user-images.githubusercontent.com/64950861/116169490-5cfc2380-a737-11eb-8c41-de01ec096fde.png) - [ ] **Past Swaps** - Occasionally, you'll see an entry that you just removed 0.5s ago reappear because the wallet updated in the background. There's potentially more. ---- Changing to a "edit, then press Save to finalize" model is one way to solve this, but not necessarily the best.

tzarebczan commented

2021-04-26 21:08:21 +02:00

(Migrated from github.com)

tzarebczan commented

2021-05-03 18:44:29 +02:00

(Migrated from github.com)

This also happens when the first action you take is a button (i.e. follow) when clicking in a page, since that action triggers a sync (on focus) + then the follow.

tzarebczan commented

2021-09-09 19:54:01 +02:00

(Migrated from github.com)

Noticed this creep up again when trying to change autoplay setting too quickly - it reverts the change and is poor UX.

keikari commented

2021-10-03 00:36:30 +02:00

(Migrated from github.com)

This also makes editing claim order in playlists quite annoying. Changes to order revert themselves sometimes really often/quickly. I think it's caused by this same thing.

Same problem when adding video to playlists, checks in "+Save" pop-up will sometimes revert to previous state after click.

This also makes editing claim order in playlists quite annoying. Changes to order revert themselves sometimes really often/quickly. I think it's caused by this same thing. Same problem when adding video to playlists, checks in "+Save" pop-up will sometimes revert to previous state after click.