own comments show first in controversial / best #5905 #5939

Merged

saltrafael merged 4 commits from comments into master

2021-05-15 06:56:58 +02:00

saltrafael commented

2021-04-24 03:51:21 +02:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: #5905

## PR Checklist  Please check all that apply to this PR using "x": - [X] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [X] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [X] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #5905

DispatchCommit (Migrated from github.com) reviewed 2021-04-24 03:51:21 +02:00

neb-b commented

2021-04-26 20:32:50 +02:00

(Migrated from github.com)

I think this will need some additional work. With this solution, your comment may disappear immediately after posting it because it will go to the bottom of the list when using "Best" sorting.

I think ideally it would be added to the top of the results, then when you refresh it will be sorted properly

I think this will need some additional work. With this solution, your comment may disappear immediately after posting it because it will go to the bottom of the list when using "Best" sorting. I think ideally it would be added to the top of the results, then when you refresh it will be sorted properly

saltrafael commented

2021-04-27 20:47:12 +02:00

(Migrated from github.com)

I think ideally it would be added to the top of the results, then when you refresh it will be sorted properly

How about this? The only problem now is if you made multiple comments they all move to the top at once, but once you refresh they all go to proper sorting. I will try to fix the multiple comments issue

> I think ideally it would be added to the top of the results, then when you refresh it will be sorted properly How about this? The only problem now is if you made multiple comments they all move to the top at once, but once you refresh they all go to proper sorting. I will try to fix the multiple comments issue

saltrafael commented

2021-04-27 21:31:10 +02:00

(Migrated from github.com)

@seanyesmunt Check if this is how it is intended now