Ensure consistent ratio for thumbnails #595

Closed
opened 2017-09-20 17:43:31 +02:00 by MSFTserver · 3 comments
MSFTserver commented 2017-09-20 17:43:31 +02:00 (Migrated from github.com)

Ticket addendum. The proper solution for this ticket is likely not to expand the images, but to keep the ratio used consistent (or at least ensure all the ratios used look good).

The Issue

thumbnail sizes in browsing section displays them as squares but doesnt properly resize the thumbnail and cuts off sides of the images

Steps to reproduce

  1. browse any videos in the search bar
  2. notice some videos thumbnails are cut off
  3. go to link thumbnails are displayed normally

Expected behaviour

Tell us what should happen
thumbnails to auto resize to squares or change them to rectangles

Actual behaviour

Tell us what happens instead
thumbnails just get cut off and it looks horrible imo

System Configuration

  • LBRY Daemon version: 0.15.2
  • LBRY App version: 0.15.1
  • LBRY Installation ID: 4xUNfNEDfK5irh7vPgMgvBUoxjAosAmJK4m5n5idPiw6hMGmj8feMYKWWvcfAokPM8
  • Operating system: Windows (Windows-2012ServerR2-6.3.9600)

Screenshots

Before

image

After

image

**Ticket addendum**. The proper solution for this ticket is likely not to expand the images, but to keep the ratio used consistent (or at least ensure all the ratios used look good). <!-- Thanks for reporting an issue to LBRY and helping us improve! To make it possible for us to help you, please fill out below information carefully. Before reporting any issues, please make sure that you're using the latest version. - App releases: https://github.com/lbryio/lbry-app/releases - Standalone daemon: https://github.com/lbryio/lbry/releases We are also available on Slack at https://slack.lbry.io --> ## The Issue thumbnail sizes in browsing section displays them as squares but doesnt properly resize the thumbnail and cuts off sides of the images ### Steps to reproduce 1. browse any videos in the search bar 2. notice some videos thumbnails are cut off 3. go to link thumbnails are displayed normally ### Expected behaviour Tell us what should happen thumbnails to auto resize to squares or change them to rectangles ### Actual behaviour Tell us what happens instead thumbnails just get cut off and it looks horrible imo ## System Configuration <!-- For the app, this info is in the About section at the bottom of the Help page. You can include a screenshot instead of typing it out --> <!-- For the daemon, run: curl 'http://localhost:5279' --data '{"method":"version"}' and include the full output --> - LBRY Daemon version: 0.15.2 - LBRY App version: 0.15.1 - LBRY Installation ID: 4xUNfNEDfK5irh7vPgMgvBUoxjAosAmJK4m5n5idPiw6hMGmj8feMYKWWvcfAokPM8 - Operating system: Windows (Windows-2012ServerR2-6.3.9600) ## Screenshots <!-- If a screenshot would help explain the bug, please include one or two here --> ### Before ![image](https://user-images.githubusercontent.com/18357967/30652990-b3cd599c-9dde-11e7-878b-f03e84370ac6.png) ### After ![image](https://user-images.githubusercontent.com/18357967/30653462-fb5da9dc-9ddf-11e7-8bb5-e4d53cff2f8d.png)
btzr-io commented 2017-09-23 06:28:12 +02:00 (Migrated from github.com)

@MSFTserver I'll add this in redesign todo list

@MSFTserver I'll add this in `redesign` todo list
kauffj commented 2017-09-26 15:14:44 +02:00 (Migrated from github.com)

@btzr-io see amendment at top

@btzr-io see amendment at top
neb-b commented 2018-02-27 18:36:37 +01:00 (Migrated from github.com)

This will be fixed with the redesign

This will be fixed with the redesign
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#595
No description provided.