Theme color problems #5998

Closed
opened 2021-05-03 11:03:16 +02:00 by infinite-persistence · 6 comments
infinite-persistence commented 2021-05-03 11:03:16 +02:00 (Migrated from github.com)
=== Fixed items ===
  • Odysee Light
    • Snack invisible.
    • I think the upload progress bar color is always at 100%.
  • Odysee Dark
    • Snack in the wrong color
      • Orange feels wrong. Previously, it was green.
    • Nag bar color seems inversed with Light -- too dim in Light, too jarring in Dark.
      • image
      • image
  • Desktop Dark
  • Desktop Light
    • Invisible nag
      • image
  • Others
    • Checkbox gap lost (checkbox touching the formfield)
      • Not related to theme, but seem to happen after then theme cleanup?
      • image
<details> <summary>=== Fixed items ===</summary> - **Odysee Light** - [X] Snack invisible. - _Closed by #5989_ - [x] I think the upload progress bar color is always at 100%. - **Odysee Dark** - [x] Snack in the wrong color - Orange feels wrong. Previously, it was green. - [x] Nag bar color seems inversed with Light -- too dim in Light, too jarring in Dark. - ![image](https://user-images.githubusercontent.com/64950861/117562991-6c835100-b0d5-11eb-9440-18e81c05632c.png) - ![image](https://user-images.githubusercontent.com/64950861/117563009-86bd2f00-b0d5-11eb-8a61-ee6561507714.png) - **Desktop Dark** - [x] "Banner" title. - ![image](https://user-images.githubusercontent.com/64950861/116858267-b0d3a480-ac30-11eb-9984-3e54a4c5c89f.png) - [x] Loading bar - ![image](https://user-images.githubusercontent.com/64950861/117775108-bf434100-b26c-11eb-9037-2fd391ebe13a.png) - [x] Nag bar text not legible. - ![image](https://user-images.githubusercontent.com/64950861/116858351-cf39a000-ac30-11eb-9a46-8b29151ad33c.png) - [x] Any error/red text (`error__text`) over the dark body. - ![image](https://user-images.githubusercontent.com/64950861/117595238-dc93e480-b172-11eb-8223-5a4c1d95fc23.png) - [x] #6006 [- dark theme on LBRY desktop is now blueish?](https://github.com/lbryio/lbry-desktop/issues/6006) - [x] Checkbox (or at least the tick mark) is a bit dim; feels like grayed out. - ![image](https://user-images.githubusercontent.com/64950861/117594562-e9173d80-b170-11eb-96fd-92c1656cf15f.png) - **Desktop Light** - [x] Invisible nag - ![image](https://user-images.githubusercontent.com/64950861/117665776-c408e600-b1d5-11eb-91fd-141df89da5a4.png) </details> - **Others** - [ ] Checkbox gap lost (checkbox touching the formfield) - Not related to theme, but seem to happen after then theme cleanup? - ![image](https://user-images.githubusercontent.com/64950861/117598592-ae1a0780-b17a-11eb-831f-4c8753845066.png)
tzarebczan commented 2021-05-10 20:46:51 +02:00 (Migrated from github.com)
  • colors off in dark mode on livestream claim:
    image
- [x] colors off in dark mode on livestream claim: ![image](https://user-images.githubusercontent.com/8120721/117709105-8b99e580-b19e-11eb-9edf-3dd6499975fe.png)
kauffj commented 2021-05-17 18:04:02 +02:00 (Migrated from github.com)

Please make sure to cover #6006 too

Please make sure to cover #6006 too
tzarebczan commented 2021-05-19 19:51:18 +02:00 (Migrated from github.com)
  • Seeing the theme go blue when a modal pops up. There's a change in color on Odysee branch also when this happens (but not as apparent)
    image
- [x] Seeing the theme go blue when a modal pops up. There's a change in color on Odysee branch also when this happens (but not as apparent) ![image](https://user-images.githubusercontent.com/8120721/118860340-431eae00-b8a9-11eb-94e8-fccf9826bf8c.png)
infinite-persistence commented 2021-05-25 07:52:29 +02:00 (Migrated from github.com)

Desktop Dark

  • FormField border lost
    • image
  • Unread notifications are the same color as the backdrop. Use another color.
## Desktop Dark - [x] FormField border lost - ![image](https://user-images.githubusercontent.com/64950861/119445973-3c3be380-bd60-11eb-8070-9f1d13e7d5af.png) - [x] Unread notifications are the same color as the backdrop. Use another color.
saltrafael commented 2021-06-10 20:04:45 +02:00 (Migrated from github.com)

Not color but leaving it here:

  • Related tabs position:

  • Long names don't fit:

Not color but leaving it here: - [ ] Related tabs position: ![](https://i.postimg.cc/mrQcFxLS/image.png) - [ ] Long names don't fit: ![](https://i.postimg.cc/NMdj1BWR/image.png)
infinite-persistence commented 2021-06-21 09:59:36 +02:00 (Migrated from github.com)

Close

Created separate issue for remaining non-color related items
https://github.com/lbryio/lbry-desktop/issues/6290

### Close Created separate issue for remaining non-color related items `https://github.com/lbryio/lbry-desktop/issues/6290`
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#5998
No description provided.