Continuation of "Add release date field #5514" #6049

Merged

infinite-persistence merged 6 commits from ip/release-date into master

2021-05-15 06:10:28 +02:00

infinite-persistence commented

2021-05-11 10:05:48 +02:00

(Migrated from github.com)

Original PR:

#5514: Add release date field
- I'm creating a new PR since I couldn't figure out how update someone else's fork (I know it's possible since Sean did update mine in the past).
- The authorship of the original commits (squashed) is retained.

Test

kp.odysee.com

Changes from original PR

Upgrade to latest react-datetime-picker
Handle dark theme and general style fixes.
Fixed how "Edits" were being handled. See accompanying PR in lbry-redux (https://github.com/lbryio/lbry-redux/pull/412)

Notes

I think the calendar should only appear when the calendar button is clicked, and not when the numerical fields are clicked. It's not easy to change without forking (https://github.com/wojtekmaj/react-datetime-picker/issues/36), so I'm leaving as is for now.

## Original PR: - #5514: [Add release date field ](https://github.com/lbryio/lbry-desktop/pull/5514) - I'm creating a new PR since I couldn't figure out how update someone else's fork (I know it's possible since Sean did update mine in the past). - The authorship of the original commits (squashed) is retained. ## Test - kp.odysee.com ## Changes from original PR - Upgrade to latest react-datetime-picker - Handle dark theme and general style fixes. - Fixed how "Edits" were being handled. See accompanying PR in lbry-redux (https://github.com/lbryio/lbry-redux/pull/412) ## Notes I think the calendar should only appear when the calendar button is clicked, and not when the numerical fields are clicked. It's not easy to change without forking (`https://github.com/wojtekmaj/react-datetime-picker/issues/36`), so I'm leaving as is for now.

jessopb (Migrated from github.com) reviewed 2021-05-11 10:05:48 +02:00

infinite-persistence commented

2021-05-11 10:24:09 +02:00

(Migrated from github.com)

https://github.com/lbryio/lbry-desktop/pull/5514#issuecomment-827082580

This needs additional help text that shows when the release date is set in the future. Text is: "Setting a future timestamp does not guarantee your content is inaccessible". Assign PR to me to re-work text before shipping.

@kauffj, after talking to @tzarebczan, I ended up preventing "future" dates in the date picker. Concerns includes:

unclear how notifications would work with future dates (it should send immediately, we believe).
need to tweak homepages and potentially other areas to do < current time.

https://github.com/lbryio/lbry-desktop/pull/5514#issuecomment-827082580 > _This needs additional help text that shows when the release date is set in the future. Text is: "Setting a future timestamp does not guarantee your content is inaccessible". Assign PR to me to re-work text before shipping._ @kauffj, after talking to @tzarebczan, I ended up preventing "future" dates in the date picker. Concerns includes: - unclear how notifications would work with future dates (it should send immediately, we believe). - need to tweak homepages and potentially other areas to do `< current time`.

kauffj commented

2021-05-11 23:37:06 +02:00

(Migrated from github.com)

Above works for me. @jessopb please review and merge.

tzarebczan commented

2021-05-14 18:14:04 +02:00

(Migrated from github.com)

I filed https://github.com/lbryio/lbry-desktop/issues/6054 for future content - we're accounting for it on apis on the initial publish, but not on edits (i.e. if you change the future date). The notification would come in at the time you set the release.

Testing this out now otherwise...