LBRYCommunity/lbry-desktop

Posts: restore "Tip unlock | Claim details" component #6051

Merged

infinite-persistence merged 2 commits from ip/md-post-tip-unlock into master

2021-05-12 20:26:47 +02:00

infinite-persistence commented

2021-05-12 05:06:41 +02:00

(Migrated from github.com)

Issue

Closes #5882: tip unlock + claim id detials missing from markdown posts view

Test

kp.odysee.com

Notes

The easiest solution would be to put FileDescription into posts, but I think that goes against the clean up of the Post layout, where the focus should be on the content. The faded style of the File Details section will be too distracting, plus we don't want the File Description anyway.

Fixed by:

Make the existing "LBC amount" clickable to show credit details. An additional padlock will appear to the right if the content is yours and you have tips to unlock.
Add an "info" icon to the left to show file details.

These "link" buttons are usually lit, but I dimmed it in this case to make them stand out less. Again, focusing on Post content instead of buttons.

## Issue Closes #5882: `tip unlock + claim id detials missing from markdown posts view` ## Test kp.odysee.com ## Notes The easiest solution would be to put `FileDescription` into posts, but I think that goes against the clean up of the Post layout, where the focus should be on the content. The faded style of the File Details section will be too distracting, plus we don't want the File Description anyway. Fixed by: - Make the existing "LBC amount" clickable to show credit details. An additional padlock will appear to the right if the content is yours and you have tips to unlock. - Add an "info" icon to the left to show file details. These "link" buttons are usually lit, but I dimmed it in this case to make them stand out less. Again, focusing on Post content instead of buttons. ![image](https://user-images.githubusercontent.com/64950861/117912310-dbe58480-b311-11eb-879e-5d1176a99183.png)

jessopb (Migrated from github.com) reviewed 2021-05-12 05:06:41 +02:00

tzarebczan commented

2021-05-12 20:26:32 +02:00

(Migrated from github.com)

This is great, thank you!

This is great, thank you!

Sign in to join this conversation.

No reviewers

No labels

area: discovery

area: installer

area: livestream

area: performance

area: subscriptions

feature request

first-timers-only

good first issue

merge when green

needs: exploration

needs: grooming

needs: priority

needs: tech design

priority: blocker

priority: medium

protocol dependent

type: discussion

type: improvement

type: new feature

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#6051

No description provided.