Bring back Open File Location / way to locate downloaded file #606

New issue

Closed

opened 2017-09-22 16:36:54 +02:00 by tzarebczan · 6 comments

tzarebczan commented

2017-09-22 16:36:54 +02:00

(Migrated from github.com)

The Issue

In v16, users lost the ability to open the file explorer to the location of the file. Right now they can open the file manually using Open (which opens it externally) or they can see the path in the "Downloaded to" section. So currently its difficult to locate the file because you don't even know what its called.

Maybe the solution is to add the filename to the "Downloaded to" path (need to worry about wrapping) but make it open to the file as opposed to opening the file itself? Or add another field with the filename which opens to the path?

System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

## The Issue In v16, users lost the ability to open the file explorer to the location of the file. Right now they can open the file manually using Open (which opens it externally) or they can see the path in the "Downloaded to" section. So currently its difficult to locate the file because you don't even know what its called. Maybe the solution is to add the filename to the "Downloaded to" path (need to worry about wrapping) but make it open to the file as opposed to opening the file itself? Or add another field with the filename which opens to the path? ## System Configuration   - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else  ## Screenshots

kauffj commented

2017-09-22 23:01:54 +02:00

(Migrated from github.com)

If the link for "Downloaded To" is not opening the folder when clicked, this is a bug.

If it is doing that, but you were confused, then this is just poor design.

If the link for "Downloaded To" is not opening the folder when clicked, this is a bug. If it _is_ doing that, but you were confused, then this is just poor design.

tzarebczan commented

2017-09-22 23:06:30 +02:00

(Migrated from github.com)

It opens to the folder which contains the LBRY download folder. I.e. my downloads folder is "D:\LBRY Downloads" and clicking the link goes to D:\ and highlights the LBRY Downloads folder. Not sure if that was the intention or not. The scenario I was talking about is where it highlights the particular downloaded file inside the downloads folder.

kauffj commented

2017-09-22 23:11:31 +02:00

(Migrated from github.com)

This is a bug, since it is supposed to open the folder. But I think it is a UX issue too, since the intended behavior was unclear.

btzr-io commented

2017-09-23 20:56:44 +02:00

(Migrated from github.com)

Research

Fixed in #610, but you can't select (highlight) the file in linux: platform_util_linux.cc#L70

// TODO(estade): It would be nice to be able to select the file in the file
// manager, but that probably requires extending xdg-open. For now just
// show the folder.

Fix for linux

However is still possible to do this without electron.shell,
Here is a hack / workaround for electron: shell.showItemInFolder:
https://gist.github.com/btzr-io/9175cda2940bd6ee6e91555d0b8cea4b

Test

The file opens in the default File manager and gets selected:

Ubuntu ( it should work )
Debian ( it should work )
Fedora ( it should work )
Elementary OS.

### Research Fixed in #610, but you can't select (highlight) the file in linux: [platform_util_linux.cc#L70](https://github.com/electron/electron/blob/db6d75ca90ebe23d70f40f767264f7c2d77f882e/atom/common/platform_util_linux.cc#L70) > // TODO(estade): It would be nice to be able to select the file in the file // manager, but that probably requires extending xdg-open. For now just // show the folder. ### Fix for linux <img width=500 src="https://user-images.githubusercontent.com/14793624/30777729-b6db77b6-a07e-11e7-9def-741ae88c2732.gif" /> However is still possible to do this without `electron.shell`, Here is a hack / workaround for electron: `shell.showItemInFolder`: https://gist.github.com/btzr-io/9175cda2940bd6ee6e91555d0b8cea4b ### Test The file opens in the default File manager and gets selected: - [ ] Ubuntu ( it should work ) - [ ] Debian ( it should work ) - [ ] Fedora ( it should work ) - [X] Elementary OS.

btzr-io commented

2017-09-24 00:49:08 +02:00

(Migrated from github.com)

Needs more test and some confirmation / feedback to send a PR 😛

Needs more test and some confirmation / feedback to send a PR :stuck_out_tongue:

btzr-io commented

2017-09-24 04:46:20 +02:00

(Migrated from github.com)

This needs to be merged first: https://github.com/lbryio/lbry-app/pull/610