Force video autoplay when a timestamp is present in URL #6064

Merged

mayeaux merged 1 commit from force-autoplay-when-timestamped into master

2021-05-15 07:59:21 +02:00

mayeaux commented

2021-05-14 00:18:17 +02:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: #5309

What is the current behavior?

A timestamped video will not autoplay if autoplay is turned off

What is the new behavior?

Even if autoplay is turned off for the user, the video will autoplay if a timestamp is present

Other information

I don't know if this is the best design in the world, perhaps it would be more appropriate have a React component hook into the Prop value to automatically pre-empt and change it, but it's a simple and working solution, really I'd like to talk to someone who is more familiar with the codebase and ask for their take but I can confirm this as a working solution.

## PR Checklist  Please check all that apply to this PR using "x": - [X] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [X] I have checked that this PR does not introduce a breaking change - [X] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [X] Bugfix - [X] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #5309 ## What is the current behavior? A timestamped video will not autoplay if autoplay is turned off ## What is the new behavior? Even if autoplay is turned off for the user, the video will autoplay if a timestamp is present ## Other information I don't know if this is the best design in the world, perhaps it would be more appropriate have a React component hook into the Prop value to automatically pre-empt and change it, but it's a simple and working solution, really I'd like to talk to someone who is more familiar with the codebase and ask for their take but I can confirm this as a working solution.

tzarebczan commented

2021-05-15 07:59:16 +02:00

(Migrated from github.com)

Congrats on the first PR, thank you! And thanks for the comments on some of the other issues...hope to see more!