LBRYCommunity/lbry-desktop

Fork 0

Transaction List - categorize and fix amount for abandon transactions #608

New issue

Closed

opened 2017-09-23 00:01:32 +02:00 by tzarebczan · 10 comments

tzarebczan commented

2017-09-23 00:01:32 +02:00

(Migrated from github.com)

The Issue

Currently, a claim or channel abandoning transaction shows as a "Spend" and only displays the fee (twice). It should be possible to determine when a transaction is an abandon and show the reclaimed LBC (positive) as the Amount. The claim name should also be shown (even though it's abandoned - it will go to a blank claim)

Opened https://github.com/lbryio/lbry/issues/946 on the lbry side - this is where the fix/enhancement needs to occur. After we have the amount/data correctly, categorize on the app side.

Expected behaviour

Abandon tx should be categorized as such and show amount of deposit returned

Actual behaviour

Abandon tx treated as a spend and shows fee as amount - can't tell how many credits came back to the wallet.

System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

## The Issue Currently, a claim or channel abandoning transaction shows as a "Spend" and only displays the fee (twice). It should be possible to determine when a transaction is an abandon and show the reclaimed LBC (positive) as the Amount. The claim name should also be shown (even though it's abandoned - it will go to a blank claim) Opened https://github.com/lbryio/lbry/issues/946 on the lbry side - this is where the fix/enhancement needs to occur. After we have the amount/data correctly, categorize on the app side. ### Expected behaviour Abandon tx should be categorized as such and show amount of deposit returned ### Actual behaviour Abandon tx treated as a spend and shows fee as amount - can't tell how many credits came back to the wallet. ## System Configuration   - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else  ## Screenshots

kauffj commented

2017-09-25 18:23:33 +02:00

(Migrated from github.com)

@hackrush01 good one for you?

tzarebczan commented

2017-10-11 18:54:16 +02:00

(Migrated from github.com)

https://explorer.lbry.io/tx/fd8db31c0087a48823dd13bc0b933aa8ee049ef61064af591a139a21029819c2

transaction_list

 {
    "claim_info": [],
    "confirmations": 1,
    "date": "2017-10-11 12:53",
    "fee": 9.6e-05,
    "support_info": [],
    "timestamp": 1507740834,
    "txid": "fd8db31c0087a48823dd13bc0b933aa8ee049ef61064af591a139a21029819c2",
    "update_info": [],
    "value": -9.6e-05
  }

![abandon](https://user-images.githubusercontent.com/8120721/31454386-4953468e-ae83-11e7-9b47-3914f49b4183.JPG) https://explorer.lbry.io/tx/fd8db31c0087a48823dd13bc0b933aa8ee049ef61064af591a139a21029819c2 transaction_list ``` { "claim_info": [], "confirmations": 1, "date": "2017-10-11 12:53", "fee": 9.6e-05, "support_info": [], "timestamp": 1507740834, "txid": "fd8db31c0087a48823dd13bc0b933aa8ee049ef61064af591a139a21029819c2", "update_info": [], "value": -9.6e-05 } ```

tzarebczan commented

2017-10-11 22:05:08 +02:00

(Migrated from github.com)

Issue moved to lbryio/lbry #946 for daemon related changes.

Issue moved to [lbryio/lbry #946](https://github.com/lbryio/lbry/issues/946) for daemon related changes.

kauffj commented

2017-10-31 14:37:13 +01:00

(Migrated from github.com)

Blocked by https://github.com/lbryio/lbryum/pull/159

kauffj commented

2017-11-07 15:50:25 +01:00

(Migrated from github.com)

App will need to use new balance_delta field provided by LBRY API.

App will need to use new `balance_delta` field provided by LBRY API.

tzarebczan commented

2017-12-05 15:51:12 +01:00

(Migrated from github.com)

@kauffj what terminology should we use to categorize these in the tx list/filter? Abandon? Revoke? Delete?

This applies to tips/supports/claims/channels that are abandoned.

@kauffj what terminology should we use to categorize these in the tx list/filter? Abandon? Revoke? Delete? This applies to tips/supports/claims/channels that are abandoned.

kauffj commented

2017-12-05 20:13:08 +01:00

(Migrated from github.com)

Not delete, since this is mildly erroneous (nothing is ever deleted from the blockchain).

I think abandon (abandoned?) is good.

Not delete, since this is mildly erroneous (nothing is ever deleted from the blockchain). I think abandon (abandoned?) is good.

kauffj commented

2017-12-05 20:13:22 +01:00

(Migrated from github.com)

Revoke is also good though.

lyoshenka commented

2018-01-26 16:46:01 +01:00