Channel Create: Sanitize URL-based thumbnail like in Claim Create #6097

Closed
opened 2021-05-20 09:10:11 +02:00 by infinite-persistence · 1 comment
infinite-persistence commented 2021-05-20 09:10:11 +02:00 (Migrated from github.com)

Original: #4481 Issues with new Channel Creation page

The thumbnail-uploader in the Channel Creation page allows URL-based thumbnails, but doesn't check if the URL is valid. We currently do that for Claim thumbnails, so I think the same method can be repeated here.

Not sure if we current crawl Channel claims or not, but a bad thumbnail would lower the score / make it look bad.

<sub>Original: [#4481 Issues with new Channel Creation page](https://github.com/lbryio/lbry-desktop/issues/4481) </sub> The thumbnail-uploader in the Channel Creation page allows URL-based thumbnails, but doesn't check if the URL is valid. We currently do that for Claim thumbnails, so I think the same method can be repeated here. Not sure if we current crawl Channel claims or not, but a bad thumbnail would lower the score / make it look bad.
tzarebczan commented 2021-07-13 22:23:02 +02:00 (Migrated from github.com)

Ran into this also, would be nice to get the connected PR in. I'll re-test the recent changes again soon.

Ran into this also, would be nice to get the connected PR in. I'll re-test the recent changes again soon.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
LBRYCommunity/lbry-desktop#6097
No description provided.