Free download gets modal popup saying "This will purchase X for free credits" #615

New issue

Closed

opened 2017-09-25 07:40:12 +02:00 by jsigwart · 4 comments

jsigwart commented

2017-09-25 07:40:12 +02:00

(Migrated from github.com)

The Issue

Purchase modal popup appears for free items asking if you want to buy the item for free credits.

Steps to reproduce

Click to download a free video
Watch for popup

Expected behaviour

Tell us what should happen
I should not be asked if I want to spend nothing for downloading free content.

Actual behaviour

Tell us what happens instead
Purchase modal popup appears for free items asking if you want to buy the item for free credits.

System Configuration

LBRY Daemon version: 0.16.1
LBRY App version: App | 0.16.0
LBRY Installation ID: 5eFxsAfhBFTKA5byNFVkGL5Lu5owWzQFthzKjRkxN2iUzWh2XNKLJAiv82mxAcq3AU
Operating system: Mac OS X 15.6.0

Screenshots

## The Issue Purchase modal popup appears for free items asking if you want to buy the item for free credits. ### Steps to reproduce 1. Click to download a free video 2. Watch for popup ### Expected behaviour Tell us what should happen I should not be asked if I want to spend nothing for downloading free content. ### Actual behaviour Tell us what happens instead Purchase modal popup appears for free items asking if you want to buy the item for free credits. ## System Configuration   - LBRY Daemon version: 0.16.1 - LBRY App version: App | 0.16.0 - LBRY Installation ID: 5eFxsAfhBFTKA5byNFVkGL5Lu5owWzQFthzKjRkxN2iUzWh2XNKLJAiv82mxAcq3AU - Operating system: Mac OS X 15.6.0 ## Screenshots  <img width="1224" alt="screen shot 2017-09-24 at 10 35 36 pm" src="https://user-images.githubusercontent.com/1363664/30793828-4d2c6ff4-a179-11e7-93d9-3c976688591d.png">

tzarebczan commented

2017-09-26 15:06:53 +02:00

(Migrated from github.com)

@jsigwart are you able to reproduce this consistently? Does it happen on all free videos? It's not happening to me on Windows. WIll try on Linux in a bit. What is your max purchase price setting in the Settings area?

jsigwart commented

2017-09-26 16:53:44 +02:00

(Migrated from github.com)

Yes, this happens with every item I try to download, free or paid. Screen grab of my settings attached.
screen shot 2017-09-26 at 7 52 38 am

Yes, this happens with every item I try to download, free or paid. Screen grab of my settings attached. <img width="819" alt="screen shot 2017-09-26 at 7 52 38 am" src="https://user-images.githubusercontent.com/1363664/30867079-cbc5229a-a28f-11e7-8f75-c2b6407011b5.png">

jsigwart commented

2017-09-26 17:00:34 +02:00

(Migrated from github.com)

I tried turning on the Single-click purchasing setting, and setting it to the minimum 0.1 LBC and cleared the application cache. I still am getting the warnings to purchase all items including free ones.

tzarebczan commented

2017-09-26 18:52:40 +02:00

(Migrated from github.com)

Ah, this is probably a regressive issue from https://github.com/lbryio/lbry-app/pull/541 / https://github.com/lbryio/lbry-app/issues/497

Didn't realize you were running from Master.

paging @alexliebowitz

Ah, this is probably a regressive issue from https://github.com/lbryio/lbry-app/pull/541 / https://github.com/lbryio/lbry-app/issues/497 Didn't realize you were running from Master. paging @alexliebowitz