Better preview for content #620

Closed
opened 2017-09-26 05:37:15 +02:00 by btzr-io · 5 comments
btzr-io commented 2017-09-26 05:37:15 +02:00 (Migrated from github.com)

Update

See https://github.com/lbryio/lbry-app/issues/620#issuecomment-375822739

The Issue

The preview component seems to give priority for videos and
this affects the rest of the published content ( files ) 😞

Steps to reproduce

  1. Publish a content that isn't a video, audio or image.
  2. Go to the claim page and see the preview.

Expected behaviour

Support multiple preview layouts ( or a better and clean generic viewer ) for the specific content type, and display and empty state when the app can't preview the content
(non-supported videos / audio, binary files...)
See -> https://github.com/lbryio/lbry-app/issues/551

Actual behaviour

Already explain this -> Poor ux
See the gif below...

Screenshots

really-bad-ux

Anything else

Related issue: https://github.com/lbryio/lbry-app/issues/482 https://github.com/lbryio/lbry-app/issues/563

## Update See https://github.com/lbryio/lbry-app/issues/620#issuecomment-375822739 ## The Issue The preview component seems to give priority for videos and this affects the rest of the published content ( files ) :disappointed: ### Steps to reproduce 1. Publish a content that isn't a video, audio or image. 2. Go to the claim page and see the preview. ### Expected behaviour Support multiple preview layouts ( or a better and clean generic viewer ) for the specific content type, and display and empty state when the app can't preview the content (non-supported videos / audio, binary files...) See -> https://github.com/lbryio/lbry-app/issues/551 ### Actual behaviour Already explain this -> Poor `ux` See the gif below... ## Screenshots <!-- If a screenshot would help explain the bug, please include one or two here --> ![really-bad-ux](https://user-images.githubusercontent.com/14793624/30841834-7a5667d8-a23b-11e7-9b6e-2c587e093a23.gif) ### Anything else Related issue: https://github.com/lbryio/lbry-app/issues/482 https://github.com/lbryio/lbry-app/issues/563
btzr-io commented 2017-10-11 05:53:57 +02:00 (Migrated from github.com)

The current preview of files sucks and has a really poor ux, but it's render-media fault 😛

The current preview of files sucks and has a really poor ux, but it's `render-media` fault :stuck_out_tongue:
kauffj commented 2017-10-11 15:53:41 +02:00 (Migrated from github.com)

Render media is actually only like 350 lines of JavaScript, FWIW

Render media is actually only like 350 lines of JavaScript, FWIW
btzr-io commented 2017-10-12 03:11:18 +02:00 (Migrated from github.com)

the problem is that returns an iframe, so we don't have much control on the styles 🙃

the problem is that returns an iframe, so we don't have much control on the styles :upside_down_face:
LavRadis commented 2018-03-24 00:17:47 +01:00 (Migrated from github.com)

Is it possible to have multiple preview modules for different content types? I discussed it with @btzr-io and he agrees. Maybe the dev team can add a simple one for odf, txt or pdf to enable preview of those file types. I just googled and found: http://viewerjs.org/ There are probably many more open sourced viewers that could be embedded to improve the user experience. Personally, I would like to see a 3d model preview (stl, obj) and some sort of gps data preview.

Is it possible to have multiple preview modules for different content types? I discussed it with @btzr-io and he agrees. Maybe the dev team can add a simple one for odf, txt or pdf to enable preview of those file types. I just googled and found: http://viewerjs.org/ There are probably many more open sourced viewers that could be embedded to improve the user experience. Personally, I would like to see a 3d model preview (stl, obj) and some sort of gps data preview.
btzr-io commented 2018-03-24 06:25:14 +01:00 (Migrated from github.com)

Possible solution would be to make a fork of render-media and integrate viewerjs as suggested by @LavRadis

Possible solution would be to make a fork of `render-media` and integrate `viewerjs` as suggested by @LavRadis
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#620
No description provided.