Setting Max Purchase Price to blank (and then No Limit) produces errors #624

Closed
opened 2017-09-26 15:19:29 +02:00 by tzarebczan · 1 comment
tzarebczan commented 2017-09-26 15:19:29 +02:00 (Migrated from github.com)

The Issue

If you set the Max Purchase Price in Settings to blank, you get this error: float argument required, not NoneType (LBC setting)/ float argument required, not unicode (USD setting) when purchasing content.

If you leave it blank and change the setting to No Limit, you still get the above errors.

Steps to reproduce

  1. Blank out the Max Purchase Price in Settings
  2. Try to purchase a video
  3. Error
  4. Set to no limit
  5. Error

Expected behaviour

LBRY app should not allow blank value, set blank to 0

Actual behaviour

Not user-friendly behavior with the error messages

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

<!-- Thanks for reporting an issue to LBRY and helping us improve! To make it possible for us to help you, please fill out below information carefully. Before reporting any issues, please make sure that you're using the latest version. - App releases: https://github.com/lbryio/lbry-app/releases - Standalone daemon: https://github.com/lbryio/lbry/releases We are also available on Slack at https://slack.lbry.io --> ## The Issue If you set the Max Purchase Price in Settings to blank, you get this error: `float argument required, not NoneType` (LBC setting)/ `float argument required, not unicode `(USD setting) when purchasing content. If you leave it blank and change the setting to No Limit, you still get the above errors. ### Steps to reproduce 1. Blank out the Max Purchase Price in Settings 2. Try to purchase a video 3. Error 4. Set to no limit 5. Error ### Expected behaviour LBRY app should not allow blank value, set blank to 0 ### Actual behaviour Not user-friendly behavior with the error messages ## System Configuration <!-- For the app, this info is in the About section at the bottom of the Help page. You can include a screenshot instead of typing it out --> <!-- For the daemon, run: curl 'http://localhost:5279' --data '{"method":"version"}' and include the full output --> - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else <!-- Include anything else that does not fit into the above sections --> ## Screenshots <!-- If a screenshot would help explain the bug, please include one or two here -->
kauffj commented 2017-09-29 22:06:04 +02:00 (Migrated from github.com)

Just fixed, will be out in 0.16.1 shortly.

Just fixed, will be out in 0.16.1 shortly.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbry-desktop#624
No description provided.