LBRYCommunity/lbry-desktop

Fork 0

i18n: Added missing state handling for RTL languages #6275

Merged

marko-lorentz merged 8 commits from master into master

2021-07-16 19:51:08 +02:00

marko-lorentz commented

2021-06-18 17:50:12 +02:00

(Migrated from github.com)

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: #4430

What is the current behavior?

RTL languages are not rendered correctly in RTL mode but in LTR.
Arabic language is not offered in language switcher.

What is the new behavior?

Arabic language available in language switcher.
Rendering of RTL languages should be fixed and will follow the choice of the current language for Arabic, Urdu and Farsi.

Other information

Some translation updates in Transifex needed for Arabic. Will be done asap.

## PR Checklist  Please check all that apply to this PR using "x": - [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [x] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: #4430 ## What is the current behavior? * RTL languages are not rendered correctly in RTL mode but in LTR. * Arabic language is not offered in language switcher. ## What is the new behavior? * Arabic language available in language switcher. * Rendering of RTL languages should be fixed and will follow the choice of the current language for Arabic, Urdu and Farsi. ## Other information Some translation updates in Transifex needed for Arabic. Will be done asap.

jessopb (Migrated from github.com) reviewed 2021-06-18 17:50:12 +02:00

tzarebczan commented

2021-06-23 00:33:24 +02:00

(Migrated from github.com)

Hey @marko-lorentz , thanks so much for the PR. Please give us a few days to take a look and review.

Can we show you some appreciation?

Hey @marko-lorentz , thanks so much for the PR. Please give us a few days to take a look and review. Can we show you some [appreciation](https://lbry.com/faq/appreciation)?

marko-lorentz commented

2021-06-23 07:10:56 +02:00

(Migrated from github.com)

Hi @tzarebczan,
The work on issue #4430 (as well as most of the Arabic translations in Transifex) was mainly done by my working student @sanabhass as an exercise. I will ask her so send her data to the given email address for supporters. I think she will be happy when her work is honoured.

(Seems that we didn't run lint properly. I will try to have a look at this later.)

Hi @tzarebczan, The work on issue #4430 (as well as most of the Arabic translations in Transifex) was mainly done by my working student @sanabhass as an exercise. I will ask her so send her data to the given email address for supporters. I think she will be happy when her work is honoured. (Seems that we didn't run lint properly. I will try to have a look at this later.)

jessopb commented

2021-07-07 17:53:53 +02:00

(Migrated from github.com)

This seems to work great - it looks like we have some issues with our translation service files such as
"Log in to %SITE_NAME% to earn rewards": "سجّل الدخول إلى٪ SITE_NAME٪ لتربح المكافآت",
That break in some places.
We'll take a look at this and see what can be done in the next few days.

This seems to work great - it looks like we have some issues with our translation service files such as `"Log in to %SITE_NAME% to earn rewards": "سجّل الدخول إلى٪ SITE_NAME٪ لتربح المكافآت",` That break in some places. We'll take a look at this and see what can be done in the next few days.

marko-lorentz commented

2021-07-07 18:07:30 +02:00

(Migrated from github.com)

Did we break it in Transifex?
On some of the translated strings it seems that the SPACE that should be behind the % jumped in front of it because of the automatic direction change that Transifex did during the typing when it discovered that Arabic letters were typed.

Pls ping me if we should try to fix it.

Did we break it in Transifex? On some of the translated strings it seems that the `SPACE` that should be behind the `%` jumped in front of it because of the automatic direction change that Transifex did during the typing when it discovered that Arabic letters were typed. Pls ping me if we should try to fix it.

jessopb commented

2021-07-07 18:17:26 +02:00

(Migrated from github.com)

I don't think it's your fault at all. Just have to look into it.

marko-lorentz commented

2021-07-09 15:07:09 +02:00

(Migrated from github.com)

After some string inspection:
My student and me will need to fix some translations in Transifex because one of the translators not only included SPACE in the translation tokens but also used the Arabic percent sign ٪ instead of the latin one % so the pattern matching will not work properly.

Edit: Fixing done. UI should look much better after next Transfix export.

After some string inspection: My student and me will need to fix some translations in Transifex because one of the translators not only included `SPACE` in the translation tokens but also used the Arabic percent sign `٪` instead of the latin one `%` so the pattern matching will not work properly. Edit: Fixing done. UI should look much better after next Transfix export.

jessopb commented

2021-07-16 18:49:57 +02:00

(Migrated from github.com)

Ok, just tested, looks great. Sorry how time flies. One rebase and poke me?

marko-lorentz commented

2021-07-16 19:27:01 +02:00

(Migrated from github.com)

Included latest changes from lbryio:master. Anything else I can do?