LBRYCommunity/lbry-desktop

Fork 0

Channel without claims shows "fetching content...", console error #636

New issue

Closed

opened 2017-09-28 16:32:38 +02:00 by tzarebczan · 8 comments

tzarebczan commented

2017-09-28 16:32:38 +02:00

(Migrated from github.com)

The Issue

Going to a channel without any claims (lbry://@blankchanneltest) makes it seem like the app is trying to pull something back but can't. The console produces an error:

Uncaught (in promise) TypeError: claims.forEach is not a function
    at reducers.(anonymous function) (webpack:///./js/reducers/claims.js?:149:12)
    at reducer (webpack:///./js/reducers/claims.js?:224:23)
    at combination (webpack:///./~/redux/es/combineReducers.js?:124:29)
    at batchingReducer (webpack:///./js/store.js?:108:16)
    at eval (webpack:///./~/redux-persist/es/autoRehydrate.js?:33:16)
    at dispatch (webpack:///./~/redux/es/createStore.js?:170:22)
    at eval (webpack:///./~/redux-logger/dist/redux-logger.js?:1:7760)
    at eval (webpack:///./js/store.js?:96:16)
    at eval (webpack:///./~/redux-thunk/lib/index.js?:14:16)

Steps to reproduce

Open lbry://@blankchanneltest in LBRY
App shows "fetching content..."
Console will show error

Expected behaviour

App should say that no content exists yet

Actual behaviour

App looks like its fetching, but console errors

System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

## The Issue Going to a channel without any claims (lbry://@blankchanneltest) makes it seem like the app is trying to pull something back but can't. The console produces an error: ``` Uncaught (in promise) TypeError: claims.forEach is not a function at reducers.(anonymous function) (webpack:///./js/reducers/claims.js?:149:12) at reducer (webpack:///./js/reducers/claims.js?:224:23) at combination (webpack:///./~/redux/es/combineReducers.js?:124:29) at batchingReducer (webpack:///./js/store.js?:108:16) at eval (webpack:///./~/redux-persist/es/autoRehydrate.js?:33:16) at dispatch (webpack:///./~/redux/es/createStore.js?:170:22) at eval (webpack:///./~/redux-logger/dist/redux-logger.js?:1:7760) at eval (webpack:///./js/store.js?:96:16) at eval (webpack:///./~/redux-thunk/lib/index.js?:14:16) ``` ### Steps to reproduce 1. Open lbry://@blankchanneltest in LBRY 2. App shows "fetching content..." 3. Console will show error ### Expected behaviour App should say that no content exists yet ### Actual behaviour App looks like its fetching, but console errors ## System Configuration   - LBRY Daemon version: - LBRY App version: - LBRY Installation ID: - Operating system: ## Anything Else  ## Screenshots

btzr-io commented

2017-09-30 01:04:22 +02:00

(Migrated from github.com)

@tzarebczan is this fixed on -> 0.16.1rc1 ?

@tzarebczan is this fixed on -> `0.16.1rc1` ?

btzr-io commented

2017-09-30 01:04:48 +02:00

(Migrated from github.com)

if not I'll send a PR ^

kauffj commented

2017-09-30 14:51:29 +02:00

(Migrated from github.com)

It is not fixed.

Also, FYI, 0.16.1rc1 is a "draft", which means it is not public. You can only see it since you're a collaborator on this repo.

It is not fixed. Also, FYI, 0.16.1rc1 is a "draft", which means it is not public. You can only see it since you're a collaborator on this repo.

btzr-io commented

2017-09-30 16:59:26 +02:00

(Migrated from github.com)

so #638 is not working ? 😕

so #638 is not working ? :confused:

tzarebczan commented

2017-09-30 17:21:54 +02:00

(Migrated from github.com)

@btzr-io I just tried on rc1, had same result as reported on this issue.

btzr-io commented

2017-09-30 17:24:28 +02:00

(Migrated from github.com)

@kauffj @tzarebczan yeah I know, this is fixed in lbry-app/fix-empty-channels #638 ^
that's why I sent that PR 😛

@kauffj @tzarebczan yeah I know, this is fixed in [lbry-app/fix-empty-channels](https://github.com/lbryio/lbry-app/tree/fix-empty-channels) #638 ^ that's why I sent that `PR` :stuck_out_tongue:

btzr-io commented

2017-09-30 17:35:13 +02:00

(Migrated from github.com)

kauffj commented

2017-10-02 18:32:13 +02:00

(Migrated from github.com)

Oops! My previous message was quite unclear. I meant it was not fixed in the RC.

AFAIK, your fix works. @tzarebczan you can test this in master if you like, or just wait for 0.17 rc.

Oops! My previous message was quite unclear. I meant it was not fixed in the RC. AFAIK, your fix works. @tzarebczan you can test this in master if you like, or just wait for 0.17 rc.