Improve accessibility and some minor css fixes #6470
No reviewers
Labels
No labels
accessibility
app-parity
area: creator
area: daemon
area: design
area: devops
area: discovery
area: docs
area: installer
area: internal
area: livestream
area: performance
area: proposal
area: reposts
area: rewards
area: search
area: security
area: subscriptions
area: sync
area: ux
area: viewer
area: wallet
BEAMER
channel
comments
community PR
consider soon
core team
css
dependencies
electron
Epic
feature request
first-timers-only
good first issue
hacktoberfest
help wanted
hub-dependent
icebox
Invalid
level: 0
level: 1
level: 2
level: 3
level: 4
merge when green
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
notifications
odysee
on hold
playlists
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
recsys
redesign
regression
resilience
sdk dependent
Tom's Wishlist
trending
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lbry-desktop#6470
Loading…
Reference in a new issue
No description provided.
Delete branch "accessibility"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Fixes
Issue Number: #4046, #5991, #6480, #5145, #6483, #6582, #6635, #6602, #6503
Changelog update: #6735
Todo
I haven't filed this one, but I remember someone mention accessibility issues around the playlist feature - somewhere in the pop up menus. Can you take a peek?
What issues ? Need more info
https://www.accessibility-developer-guide.com/
Skip navigation feature: Useful for screen reader users ( tested with NVDA, windows narrator )
Other apps
Reddit.com
Youtube.com
New aria-label format for claim preview links:
This includes additional information of the claim.
See youtube website for reference.
Screen reader example
Todo
Include more info ? ( file type, price ) ?
Waiting for review or feedback before any more changes.
Should I move this component to its own file ?
Split-strings are hard to translate and is something that we've been actively cleaning up.
https://phrase.com/blog/posts/10-common-mistakes-in-software-localization/#4_Concatenated_Strings
Use full sentences with variables so that translators can shift words as needed.
@ -236,6 +236,7 @@
&:focus {
box-shadow: none;
background-color: var(--color-button-alt-bg);
Fix #6503
@btzr-io , can you make one final rebase to resolve the conflicts? Will get this in soon.
One more minor fix needed
@ -0,0 +28,4 @@
}
}
return ariaLabelData;
I think we forgot to remove the
+=
?Changelog update: #6735