Comments: CPU maxed out #6473

Closed
opened 2021-07-14 05:01:14 +02:00 by infinite-persistence · 2 comments
infinite-persistence commented 2021-07-14 05:01:14 +02:00 (Migrated from github.com)

This applies to pre-pagination version too.

  • 100% CPU when resolving

    1. https://odysee.com/@Odysee:8?view=discussion.
    2. Set zoom to lowest (25%).
    3. Scroll down to load more comments. CPU is pegged at 100% for quite some time.
  • 50% CPU when left as is

    1. After the steps above, just leave as is. Notice that CPU fluctuates between 20% to 50%. It doesn't happen if I navigate back to the homepage. No idea what's happening here.

Culprits (there could be more):

  • Lots of resolves to load commenter details. Maybe need to batch this.
  • remark processing (parsing channel links, inline timestamps, etc.) on each comment. I believe it is being ran multiple times per comment (any remark experts here to check our implementation?), and also when hovered over. You can see 100% cpu when moving the mouse over a comment continuously.
This applies to pre-pagination version too. - [ ] 100% CPU when resolving 1. https://odysee.com/@Odysee:8?view=discussion. 2. Set zoom to lowest (25%). 3. Scroll down to load more comments. CPU is pegged at 100% for quite some time. <img src="https://user-images.githubusercontent.com/64950861/125552852-245c0b74-dd57-495a-832d-5854fe58788d.png" width="800"> - [ ] 50% CPU when left as is 1. After the steps above, just leave as is. Notice that CPU fluctuates between 20% to 50%. It doesn't happen if I navigate back to the homepage. No idea what's happening here. ---- Culprits (there could be more): - Lots of resolves to load commenter details. Maybe need to batch this. - `remark` processing (parsing channel links, inline timestamps, etc.) on each comment. I believe it is being ran multiple times per comment (any `remark` experts here to check our implementation?), and also when hovered over. You can see 100% cpu when moving the mouse over a comment continuously.
tzarebczan commented 2021-07-19 17:25:25 +02:00 (Migrated from github.com)

Was this from the comment react bug is it still happening?

Was this from the comment react bug is it still happening?
infinite-persistence commented 2021-07-19 20:05:54 +02:00 (Migrated from github.com)

Not related to that -- this screenshot is from pre-pagination.

Not related to that -- this screenshot is from pre-pagination.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
LBRYCommunity/lbry-desktop#6473
No description provided.