Fix comment create redirection

saltrafael commented

2021-07-19 20:18:21 +02:00

(Migrated from github.com)

Copy link

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I added a line describing my change to CHANGELOG.md
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting)
Refactoring (no functional changes)
Documentation changes
Other - Please describe:

Fixes

Issue Number: Closes #5321

## PR Checklist  Please check all that apply to this PR using "x": - [X] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged) - [X] I added a line describing my change to CHANGELOG.md - [X] I have checked that this PR does not introduce a breaking change - [ ] This PR introduces breaking changes and I have provided a detailed explanation below ## PR Type What kind of change does this PR introduce? - [X] Bugfix - [ ] Feature - [ ] Code style update (formatting) - [ ] Refactoring (no functional changes) - [ ] Documentation changes - [ ] Other - Please describe: ## Fixes Issue Number: Closes #5321

infinite-persistence (Migrated from github.com) reviewed 2021-07-19 20:18:21 +02:00

tzarebczan commented

2021-07-23 19:32:30 +02:00

(Migrated from github.com)

Copy link

Will test this out, but wanted to confirm it fixes the issue where the channel list may still be loading (looks like some of that code was removed).

The main bug was that it would tell you to create a channel because the call wasn't done loading.

Will test this out, but wanted to confirm it fixes the issue where the channel list may still be loading (looks like some of that code was removed). The main bug was that it would tell you to create a channel because the call wasn't done loading.

infinite-persistence (Migrated from github.com) requested changes 2021-07-29 10:38:26 +02:00

infinite-persistence (Migrated from github.com) left a comment

Copy link

Will test this out, but wanted to confirm it fixes the issue where the channel list may still be loading (looks like some of that code was removed).

The main bug was that it would tell you to create a channel because the call wasn't done loading.

This scenario isn't covered. If channel_list stalls, the code incorrectly thinks the user has no channels. It should probably wait until isFetchingChannels is done before enabling the section.

> _Will test this out, but wanted to confirm it fixes the issue where the channel list may still be loading (looks like some of that code was removed)._ > > _The main bug was that it would tell you to create a channel because the call wasn't done loading._ This scenario isn't covered. If `channel_list` stalls, the code incorrectly thinks the user has no channels. It should probably wait until `isFetchingChannels` is done before enabling the section.

Fix comment create redirection #6557

PR Checklist

PR Type

Fixes