comment reaction list loops with 1 channel #6561

Closed
opened 2021-07-19 22:44:50 +02:00 by tzarebczan · 1 comment
tzarebczan commented 2021-07-19 22:44:50 +02:00 (Migrated from github.com)

If a user has 1 channel, the reaction list call for comments will loop.

If a user has 1 channel, the reaction list call for comments will loop.
infinite-persistence commented 2021-07-22 07:05:24 +02:00 (Migrated from github.com)

Seems pretty stable now.

  • Since we buffer up the IDs and fetch in larger batches, it won't be 1:1 with comment.List like before (should be fewer calls when scrolling fast).
  • Can't explain the spike at 1:00 - 1:30 though. The only "extra fetch" that I know is when we switch active channels, but that should just be 1 call to catch up on all comment IDs.

image

Seems pretty stable now. - Since we buffer up the IDs and fetch in larger batches, it won't be 1:1 with `comment.List` like before (should be fewer calls when scrolling fast). - Can't explain the spike at `1:00 - 1:30` though. The only "extra fetch" that I know is when we switch active channels, but that should just be 1 call to catch up on all comment IDs. ![image](https://user-images.githubusercontent.com/64950861/126591948-6379c5da-5e99-4e6f-8b7c-d026f1a9af03.png)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
LBRYCommunity/lbry-desktop#6561
No description provided.