Form labels potentially interpreted as disabled fields #667

New issue

Closed

opened 2017-10-11 20:26:39 +02:00 by hackrush01 · 4 comments

hackrush01 commented

2017-10-11 20:26:39 +02:00

(Migrated from github.com)

The Issue

Sub-titles for headings in Publish page are shown as gray.

Steps to reproduce

Open publish page in app

Expected behaviour

They should be black, as gray color gives the feel that the button/option is disabled.

System Configuration

Latest app running from master

Screenshots

https://imgur.com/a/Te3bR

## The Issue Sub-titles for headings in Publish page are shown as gray. ### Steps to reproduce 1. Open publish page in app ### Expected behaviour They should be black, as gray color gives the feel that the button/option is disabled. ## System Configuration Latest app running from master ## Screenshots https://imgur.com/a/Te3bR

kauffj commented

2017-10-12 15:48:12 +02:00

(Migrated from github.com)

@hackrush01 do you mean the form labels? Or the text directly below the headers?

@btzr-io this did make me notice that we have both form-row__label and form-field__label, which were not styled the same prior to 45b2bc6aa8

@hackrush01 do you mean the form labels? Or the text directly below the headers? @btzr-io this did make me notice that we have both `form-row__label` and `form-field__label`, which were not styled the same prior to https://github.com/lbryio/lbry-app/commit/45b2bc6aa852d24a196d358fd10a8c31e3384d8b

hackrush01 commented

2017-10-12 17:05:26 +02:00

(Migrated from github.com)

@kauffj I mean the sub-labels, like File, Title, Thumbnail URL, Description in attached image 1, and Free, Choose Price and Deposit in attached imaged 2. Also, I seem to recall they were proper in the earlier releases.

@kauffj I mean the sub-labels, like `File`, `Title`, `Thumbnail URL`, `Description` in attached image 1, and `Free`, `Choose Price` and `Deposit` in attached imaged 2. Also, I seem to recall they were proper in the earlier releases.

kauffj commented

2017-10-13 19:34:36 +02:00

(Migrated from github.com)

@btzr-io thought you may be interested in this feedback. Perhaps the color of help text is not appropriate for form labels.

btzr-io commented

2017-10-15 05:41:01 +02:00

(Migrated from github.com)

Hover states give the input line more opacity, helping make text fields more noticeable on desktop.
https://material.io/guidelines/components/text-fields.html#text-fields-states

> Hover states give the input line more opacity, helping make text fields more noticeable on desktop. https://material.io/guidelines/components/text-fields.html#text-fields-states